[Enhancement] Migrate the alter table related logic scattered everywhere to AlterJobExecutor #48637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| } finally { | ||
| locker.unLockDatabase(db, LockType.WRITE); | ||
| } | ||
| } | ||
| } |
| } else if (alterClause instanceof CompactionClause) { | ||
| String s = (((CompactionClause) alterClause).isBaseCompaction() ? "base" : "cumulative") | ||
| + " compact " + tableName + " partitions: " + ((CompactionClause) alterClause).getPartitionNames(); | ||
| compactionHandler.process(alterClauses, db, olapTable); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
What would you like to know or talk about today?
| } | ||
| } | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
The startsWith check for partition names assumes that ExpressionRangePartitionInfo.SHADOW_PARTITION_PREFIX is not null, which could lead to a NullPointerException.
You can modify the code like this:
if (partitionName != null && partitionName.startsWith(ExpressionRangePartitionInfo.SHADOW_PARTITION_PREFIX)) {
throw new SemanticException("Replace shadow partitions is not allowed");
}
//...
if (clause.getPartitionName() != null && clause.getPartitionName().startsWith(
ExpressionRangePartitionInfo.SHADOW_PARTITION_PREFIX)) {
throw new SemanticException("Deletion of shadow partitions is not allowed");
}
List<String> partitionNames = clause.getPartitionNames();
if (CollectionUtils.isNotEmpty(partitionNames)) {
boolean hasShadowPartition = partitionNames.stream()
.anyMatch(partitionName -> partitionName != null &&
partitionName.startsWith(ExpressionRangePartitionInfo.SHADOW_PARTITION_PREFIX));
if (hasShadowPartition) {
throw new SemanticException("Deletion of shadow partitions is not allowed");
}
}
HangyuanLiu
force-pushed
the
0719-schema-change
branch
3 times, most recently
from
a0ac867
to
b2789a8
Compare
…entAnalyzer Signed-off-by: HangyuanLiu <[email protected]>
HangyuanLiu
force-pushed
the
0719-schema-change
branch
5 times, most recently
from
eabf78f
to
a5d6804
Compare
…bExecutor Signed-off-by: HangyuanLiu <[email protected]>
HangyuanLiu
force-pushed
the
0719-schema-change
branch
from
a5d6804
to
a868999
Compare
|
[FE Incremental Coverage Report]✅ pass : 138 / 150 (92.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Jul 23, 2024
stephen-shelby
approved these changes
Jul 23, 2024
stephen-shelby
approved these changes
Jul 23, 2024
meegoo
approved these changes
Jul 23, 2024
nshangyiming
approved these changes
Jul 23, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
…ere to AlterJobExecutor (#48637) Signed-off-by: HangyuanLiu <[email protected]> (cherry picked from commit b0ea263) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/alter/AlterJobExecutor.java # fe/fe-core/src/main/java/com/starrocks/alter/AlterJobMgr.java # fe/fe-core/src/main/java/com/starrocks/connector/hive/HiveMetadata.java # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableClauseAnalyzer.java # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableStatementAnalyzer.java # fe/fe-core/src/main/java/com/starrocks/sql/ast/AlterTableStmt.java # fe/fe-core/src/test/java/com/starrocks/alter/AlterTest.java # fe/fe-core/src/test/java/com/starrocks/connector/AlterTableTest.java
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ere to AlterJobExecutor (backport #48637) (#48794) Co-authored-by: HangyuanLiu <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
…ere to AlterJobExecutor (StarRocks#48637) Signed-off-by: HangyuanLiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
/*
*/
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: