-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix the race condition of addPartition operation (backport #48492) #48643
Conversation
Cherry-pick of 2a33dc9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Signed-off-by: Murphy <[email protected]> (cherry picked from commit 2a33dc9) Signed-off-by: Murphy <[email protected]> # Conflicts: # fe/fe-core/src/main/java/com/starrocks/catalog/CatalogUtils.java
51acbba
to
c29ed45
Compare
Quality Gate passedIssues Measures |
…48492) (#48643) Co-authored-by: Murphy <[email protected]>
Why I'm doing:
analyzeAddPartitionProperties
actually modify the state ofListPartitionInfo
, but it's under ReadLock, so it would introduce a race condition on theListPartitionInfo
What I'm doing:
setBatchLiteralExprValues
idToValues
is always consistent withidToLiteralExprValues
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #48492 done by [Mergify](https://mergify.com). ## Why I'm doing: - `analyzeAddPartitionProperties` actually modify the state of `ListPartitionInfo`, but it's under ReadLock, so it would introduce a race condition on the `ListPartitionInfo`
What I'm doing:
setBatchLiteralExprValues
idToValues
is always consistent withidToLiteralExprValues
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: