Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix 'PartitionKey' field of cloud native table if different with shared nothing table when run 'show partitions' command #48647

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[BugFix] Fix 'PartitionKey' field of cloud native table if different with shared nothing table when run 'show partitions' command #48647

merged 1 commit into from
Jul 22, 2024

Conversation

tracymacding
Copy link
Contributor

@tracymacding tracymacding commented Jul 20, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue https://github.com/StarRocks/StarRocksTest/issues/8019

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@tracymacding tracymacding requested a review from a team as a code owner July 20, 2024 10:07
@tracymacding tracymacding force-pushed the fix_cloud_native_table_partition_key branch from 77157ee to b437939 Compare July 20, 2024 10:11
@tracymacding tracymacding changed the title Fix 'PartitionKey' field of cloud native table if different with shared nothing table when run 'show partitions' command [BugFix] Fix 'PartitionKey' field of cloud native table if different with shared nothing table when run 'show partitions' command Jul 21, 2024
@tracymacding
[BugFix] Fix 'PartitionKey' field of cloud native table if different …
2be529e 
…with

shared nothing table when run 'show partitions' command

Signed-off-by: tracymacding <[email protected]>
@tracymacding tracymacding force-pushed the fix_cloud_native_table_partition_key branch from b437939 to 2be529e Compare July 21, 2024 03:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 21, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wyb wyb enabled auto-merge (squash) July 22, 2024 02:19
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/proc/PartitionsProcDir.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit 01c8621 into StarRocks:main Jul 22, 2024
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 22, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 22, 2024
@tracymacding @mergify
[BugFix] Fix 'PartitionKey' field of cloud native table if different …
064c189 
…with shared nothing table when run 'show partitions' command (#48647)

Signed-off-by: tracymacding <[email protected]>
(cherry picked from commit 01c8621)
@mergify mergify bot mentioned this pull request Jul 22, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 22, 2024
@mergify @tracymacding
[BugFix] Fix 'PartitionKey' field of cloud native table if different …
c8df5e5 
…with shared nothing table when run 'show partitions' command (backport #48647) (#48657)

Co-authored-by: tracymacding <[email protected]>
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
@tracymacding @dujijun007
[BugFix] Fix 'PartitionKey' field of cloud native table if different …
9bed006 
…with shared nothing table when run 'show partitions' command (StarRocks#48647)

Signed-off-by: tracymacding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@tracymacding tracymacding

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tracymacding @kevincai @wyb