Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] Fix lake compaction UT #48648

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[UT] Fix lake compaction UT #48648

merged 3 commits into from
Jul 22, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jul 20, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned wyb Jul 20, 2024
@wyb
Fix comment
28eff3e 
Signed-off-by: wyb <[email protected]>
kevincai
kevincai previously approved these changes Jul 22, 2024
View reviewed changes
@wyb
Fix format
bdeadaf 
Signed-off-by: wyb <[email protected]>
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@luohaha luohaha merged commit 507625f into StarRocks:main Jul 22, 2024
47 checks passed
@github-actions github-actions bot added the 3.3 label Jul 22, 2024
@wyb
Copy link
Contributor Author

wyb commented Jul 22, 2024

https://github.com/Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 22, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@github-actions github-actions bot added the 3.2 label Jul 22, 2024
@wyb
Copy link
Contributor Author

wyb commented Jul 22, 2024

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 22, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 22, 2024
@wyb @mergify
[UT] Fix lake compaction UT (#48648)
a6cf3ab 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 507625f)
@mergify mergify bot mentioned this pull request Jul 22, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 22, 2024
@wyb @mergify
[UT] Fix lake compaction UT (#48648)
03e8ce4 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 507625f)

# Conflicts:
#	be/test/storage/lake/compaction_test_utils.h
@mergify mergify bot mentioned this pull request Jul 22, 2024
Closed
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 22, 2024
@mergify @wyb
[UT] Fix lake compaction UT (backport #48648) (#48674)
018b20d 
Co-authored-by: wyb <[email protected]>
wyb added a commit to wyb/starrocks that referenced this pull request Jul 22, 2024
@wyb
[UT] Fix lake compaction UT (StarRocks#48648)
fbf17a1 
Signed-off-by: wyb <[email protected]>
wyb added a commit that referenced this pull request Jul 22, 2024
@wyb
[UT] Fix lake compaction UT (backport #48648) (#48688)
5069917 
Signed-off-by: wyb <[email protected]>
@wyb wyb mentioned this pull request Jul 22, 2024
Merged
24 tasks
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
@wyb @dujijun007
[UT] Fix lake compaction UT (StarRocks#48648)
e287c45 
Signed-off-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@luohaha luohaha luohaha approved these changes

@starrocks-xupeng starrocks-xupeng starrocks-xupeng approved these changes

Assignees

@wyb wyb

Labels
3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyb @kevincai @luohaha @starrocks-xupeng