Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix CTE distinct grouping sets rewrite generate invalid plan (backport #48765) #48787

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 23, 2024

Why I'm doing:

repeat node will generate null literal. which will cause exchange rpc error

fix #47316

| PLAN FRAGMENT 5(F01)                                                                                                                                                  |
|   Output Exprs:2: A | 3: B | 21: GROUPING_ID                                                                                                          |
|   Input Partition: UNPARTITIONED                                                                                                                                      |
|   MultiCastDataSinks:                                                                                                                                                 |
|   OutPut Partition: RANDOM                                                                                                                                            |
|   OutPut Exchange Id: 04                                                                                                                                              |
|   OutPut Partition: RANDOM                                                                                                                                            |
|   OutPut Exchange Id: 12                                                                                                                                              |
|                                                                                                                                                                       |
|   3:REPEAT_NODE                                                                                                                                                       |
|   |  repeat: repeat 1 lines [[2], [3]]                                                                                                                                |
|   |  cardinality: 2                                                                                                                                                   |
|   |  column statistics:                                                                                                                                               |
|   |  * one_level-->[-Infinity, Infinity, 0.0, 2.890310786106033, 18.0] ESTIMATE                                                                                       |
|   |  * two_level-->[-Infinity, Infinity, 0.0, 4.0, 1.0] ESTIMATE                                                                                                      |
|   |  * device_cmt-->[-Infinity, Infinity, 0.0, 13.673674588665447, 1094.0] ESTIMATE                                                                                   |
|   |  * online_cmt-->[-Infinity, Infinity, 0.8555758683729433, 1.9853747714808043, 157.0] ESTIMATE                                                                     |
|   |  * GROUPING_ID-->[1.0, 2.0, 0.0, 8.0, 2.0] ESTIMATE   

What I'm doing:

add a project node for pattern CTE-produce - Repeat node

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #48765 done by [Mergify](https://mergify.com). ## Why I'm doing: repeat node will generate null literal. which will cause exchange rpc error

fix #47316

| PLAN FRAGMENT 5(F01)                                                                                                                                                  |
|   Output Exprs:2: A | 3: B | 21: GROUPING_ID                                                                                                          |
|   Input Partition: UNPARTITIONED                                                                                                                                      |
|   MultiCastDataSinks:                                                                                                                                                 |
|   OutPut Partition: RANDOM                                                                                                                                            |
|   OutPut Exchange Id: 04                                                                                                                                              |
|   OutPut Partition: RANDOM                                                                                                                                            |
|   OutPut Exchange Id: 12                                                                                                                                              |
|                                                                                                                                                                       |
|   3:REPEAT_NODE                                                                                                                                                       |
|   |  repeat: repeat 1 lines [[2], [3]]                                                                                                                                |
|   |  cardinality: 2                                                                                                                                                   |
|   |  column statistics:                                                                                                                                               |
|   |  * one_level-->[-Infinity, Infinity, 0.0, 2.890310786106033, 18.0] ESTIMATE                                                                                       |
|   |  * two_level-->[-Infinity, Infinity, 0.0, 4.0, 1.0] ESTIMATE                                                                                                      |
|   |  * device_cmt-->[-Infinity, Infinity, 0.0, 13.673674588665447, 1094.0] ESTIMATE                                                                                   |
|   |  * online_cmt-->[-Infinity, Infinity, 0.8555758683729433, 1.9853747714808043, 157.0] ESTIMATE                                                                     |
|   |  * GROUPING_ID-->[1.0, 2.0, 0.0, 8.0, 2.0] ESTIMATE   

What I'm doing:

add a project node for pattern CTE-produce - Repeat node

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Jul 23, 2024

Cherry-pick of 6076570 has failed:

On branch mergify/bp/branch-3.1/pr-48765
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 6076570358.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/CTEProduceAddProjectionRule.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/AggregateTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/Optimizer.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/RuleType.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Jul 23, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Jul 23, 2024
@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-48765 branch July 23, 2024 12:10
@stdpain stdpain restored the mergify/bp/branch-3.1/pr-48765 branch August 6, 2024 02:08
@stdpain stdpain deleted the mergify/bp/branch-3.1/pr-48765 branch August 6, 2024 02:09
@stdpain stdpain restored the mergify/bp/branch-3.1/pr-48765 branch August 6, 2024 02:13
@stdpain stdpain reopened this Aug 6, 2024
@stdpain stdpain force-pushed the mergify/bp/branch-3.1/pr-48765 branch from b428def to 8ed9352 Compare August 6, 2024 02:14
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 6, 2024 02:14
Copy link

sonarcloud bot commented Aug 6, 2024

@wanpengfei-git wanpengfei-git merged commit 07d31d8 into branch-3.1 Aug 6, 2024
33 of 34 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-48765 branch August 6, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants