Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix Memory Leak in PredictionContextCache (backport #48776) #48843

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 24, 2024

Why I'm doing:

antlr/antlr4#499
When grammar rules are complex, some special statements may cause the global cache in ANTLR to grow continuously, occupying a large amount of memory.

What I'm doing:

We did not find reproducible SQL from the client's cluster. When the client encounters similar issues, we temporarily provide a parsing mode that does not use the cache. This mode is disabled by default, as enabling it will significantly reduce the parser's efficiency.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #48776 done by [Mergify](https://mergify.com). ## Why I'm doing: https://github.com/antlr/antlr4/issues/499 When grammar rules are complex, some special statements may cause the global cache in ANTLR to grow continuously, occupying a large amount of memory.

What I'm doing:

We did not find reproducible SQL from the client's cluster. When the client encounters similar issues, we temporarily provide a parsing mode that does not use the cache. This mode is disabled by default, as enabling it will significantly reduce the parser's efficiency.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Jul 24, 2024

Cherry-pick of b4826a8 has failed:

On branch mergify/bp/branch-3.2/pr-48776
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit b4826a8707.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/parser/SqlParser.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/common/Config.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Jul 24, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled July 24, 2024 07:41

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-48776 branch July 24, 2024 07:42
@packy92 packy92 restored the mergify/bp/branch-3.2/pr-48776 branch August 6, 2024 05:31
@packy92 packy92 reopened this Aug 6, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 6, 2024 05:32
@packy92 packy92 force-pushed the mergify/bp/branch-3.2/pr-48776 branch from 1d46c53 to 68f0dbc Compare August 6, 2024 06:37
Signed-off-by: packy92 <[email protected]>
Copy link

sonarcloud bot commented Aug 6, 2024

@wanpengfei-git wanpengfei-git merged commit 9007961 into branch-3.2 Aug 6, 2024
29 of 30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-48776 branch August 6, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants