Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Improve files from s3 without ak and sk error message #49090

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[Enhancement] Improve files from s3 without ak and sk error message #49090

merged 1 commit into from
Jul 30, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jul 29, 2024 •
edited
Loading

Why I'm doing:

mysql> select * from files("path" = "s3://bucket/file", "format" = "parquet");
ERROR 1064 (HY000): Access storage error. Error message: No FileSystem for scheme "s3"

What I'm doing:

mysql> select * from files("path" = "s3://bucket/file", "format" = "parquet");
ERROR 1064 (HY000): Access storage error. Error message: Unable to load credentials from system settings. Access key must be specified either via environment variable (AWS_ACCESS_KEY_ID) or system property (aws.accessKeyId).

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 3.3 label Jul 29, 2024
@mergify mergify bot assigned wyb Jul 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added 3.2 and removed 3.2 labels Jul 29, 2024
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/fs/hdfs/HdfsFsManager.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions github-actions bot added the 3.2 label Jul 29, 2024
@wyb wyb requested a review from Smith-Cruise July 30, 2024 02:05
@meegoo meegoo enabled auto-merge (squash) July 30, 2024 02:53
@meegoo meegoo merged commit 576c814 into StarRocks:main Jul 30, 2024
69 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 30, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 30, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 30, 2024
@wyb @mergify
[Enhancement] Improve files from s3 without ak and sk error message (#…
7f5a93e 
…49090)

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 576c814)
@mergify mergify bot mentioned this pull request Jul 30, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 30, 2024
@wyb @mergify
[Enhancement] Improve files from s3 without ak and sk error message (#…
1859ead 
…49090)

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 576c814)
@mergify mergify bot mentioned this pull request Jul 30, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 30, 2024
@mergify @wyb
[Enhancement] Improve files from s3 without ak and sk error message (…
d6d46fd 
…backport #49090) (#49167)

Co-authored-by: wyb <[email protected]>
@wyb
Copy link
Contributor Author

wyb commented Jul 31, 2024

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot added the 3.3 label Jul 31, 2024
mergify bot pushed a commit that referenced this pull request Jul 31, 2024
@wyb @mergify
[Enhancement] Improve files from s3 without ak and sk error message (#…
7070961 
…49090)

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 576c814)
@mergify mergify bot mentioned this pull request Jul 31, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 31, 2024
@mergify @wyb
[Enhancement] Improve files from s3 without ak and sk error message (…
7286600 
…backport #49090) (#49193)

Co-authored-by: wyb <[email protected]>
@wyb
Copy link
Contributor Author

wyb commented Jul 31, 2024

ignore backport check: 3.3.2

wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @wyb
[Enhancement] Improve files from s3 without ak and sk error message (…
9507e5a 
…backport #49090) (#49166)

Co-authored-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smith-Cruise Smith-Cruise Smith-Cruise approved these changes

@jaogoy jaogoy jaogoy approved these changes

@meegoo meegoo meegoo approved these changes

Assignees

@wyb wyb

Labels
3.1-merged 3.1 3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyb @meegoo @jaogoy @Smith-Cruise