Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] use JAVA_HOME from maven (backport #49128) #49179

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 30, 2024

Why I'm doing:

When running maven install, got JAVA_HOME not found in python script.

What I'm doing:

Add environment variable using maven properties(BTW prevent maven and python use different JAVA_HOME)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #49128 done by [Mergify](https://mergify.com). ## Why I'm doing:

When running maven install, got JAVA_HOME not found in python script.

What I'm doing:

Add environment variable using maven properties(BTW prevent maven and python use different JAVA_HOME)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

## Why I'm doing:

When running maven install, got JAVA_HOME not found in python script.

## What I'm doing:

Add environment variable using maven properties(BTW prevent maven and python use different JAVA_HOME)

Signed-off-by: void-mian <[email protected]>
(cherry picked from commit 892cad8)
@mergify mergify bot mentioned this pull request Jul 30, 2024
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) July 30, 2024 20:32
Copy link

sonarcloud bot commented Jul 30, 2024

@wanpengfei-git wanpengfei-git merged commit 3c60219 into branch-3.3 Aug 8, 2024
36 of 37 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-49128 branch August 8, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants