-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] count memory usage of approx_top_k&percentile_cont agg state #49232
[Enhancement] count memory usage of approx_top_k&percentile_cont agg state #49232
Conversation
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
This reverts commit 9c31a66. Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
a2b86a6
to
72204a8
Compare
Signed-off-by: silverbullet233 <[email protected]>
c183ae3
to
e982071
Compare
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 20 / 20 (100.00%) file detail
|
@@ -1187,6 +1196,7 @@ void Analytor::_find_candidate_peer_group_ends() { | |||
} | |||
|
|||
void Analytor::_get_window_function_result(size_t frame_start, size_t frame_end) { | |||
SCOPED_THREAD_LOCAL_AGG_STATE_ALLOCATOR_SETTER(_allocator.get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_get_window_function_result will assign result for each rows.
// DO NOT put timer here because this function will be used frequently,
// timer will cause a sharp drop in performance.
Will this cause a performance regression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_get_window_function_result will assign result for each rows.
// DO NOT put timer here because this function will be used frequently, // timer will cause a sharp drop in performance.
Will this cause a performance regression?
No, in analytor, we just use MemHookAllocator, the logic is the same as before. there is no new timer introduced
since #49206 support count the memory usage from delta. |
Why I'm doing:
What I'm doing:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: