Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support write vector index #49346

Conversation

dujijun007
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #46678

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@dujijun007 dujijun007 requested review from a team as code owners August 2, 2024 11:36
@wanpengfei-git wanpengfei-git requested a review from a team August 2, 2024 11:37
@dujijun007
Copy link
Contributor Author

dujijun007 commented Aug 2, 2024

Split pr #48398 into two prs, the preview pr #49220 has been merged.

@dujijun007 dujijun007 force-pushed the main-support-write-with-vector-index branch from 23d6e96 to 06850d0 Compare August 2, 2024 12:17
gensrc/proto/data.proto Outdated Show resolved Hide resolved
gensrc/proto/types.proto Outdated Show resolved Hide resolved
kevincai
kevincai previously approved these changes Aug 3, 2024
@dujijun007 dujijun007 force-pushed the main-support-write-with-vector-index branch from 83d306f to 728f7f4 Compare August 3, 2024 07:25
kevincai
kevincai previously approved these changes Aug 5, 2024
be/src/common/config.h Outdated Show resolved Hide resolved
@dujijun007 dujijun007 force-pushed the main-support-write-with-vector-index branch from 237257c to 78535ba Compare August 6, 2024 06:35
@dujijun007 dujijun007 force-pushed the main-support-write-with-vector-index branch from 0454eb4 to b84378b Compare August 7, 2024 08:05
Copy link

sonarcloud bot commented Aug 7, 2024

Copy link

github-actions bot commented Aug 7, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Aug 7, 2024

[BE Incremental Coverage Report]

fail : 151 / 281 (53.74%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/segment_replicate_executor.cpp 1 27 03.70% [318, 320, 321, 322, 323, 324, 326, 327, 328, 329, 332, 333, 334, 335, 337, 338, 339, 341, 342, 343, 344, 345, 346, 347, 348, 351]
🔵 be/src/storage/index/index_descriptor.h 1 11 09.09% [29, 31, 32, 33, 34, 35, 36, 37, 48, 51]
🔵 be/src/storage/rowset/rowset_writer.cpp 7 51 13.73% [300, 301, 303, 304, 305, 306, 307, 308, 310, 314, 317, 320, 322, 323, 324, 325, 326, 328, 329, 330, 331, 333, 335, 336, 337, 338, 340, 343, 344, 345, 348, 350, 448, 449, 465, 1127, 1128, 1129, 1130, 1131, 1132, 1133, 1134, 1135]
🔵 be/src/storage/rowset/rowset.cpp 3 15 20.00% [329, 330, 331, 332, 333, 442, 443, 444, 445, 446, 447, 448]
🔵 be/src/storage/rowset/segment_writer.cpp 5 10 50.00% [186, 187, 188, 189, 190]
🔵 be/src/storage/rowset/array_column_writer.cpp 10 19 52.63% [131, 132, 133, 134, 145, 175, 187, 212, 237]
🔵 be/src/storage/index/vector/vector_index_builder_factory.cpp 4 6 66.67% [32, 33]
🔵 be/src/storage/index/vector/vector_index_writer.h 5 7 71.43% [37, 55]
🔵 be/src/storage/index/vector/vector_index_writer.cpp 52 69 75.36% [38, 53, 54, 56, 62, 79, 107, 108, 119, 120, 127, 128, 129, 130, 131, 133, 134]
🔵 be/src/storage/index/vector/vector_index_builder.h 9 12 75.00% [68, 70, 72]
🔵 be/src/storage/tablet_meta.h 1 1 100.00% []
🔵 be/src/util/system_metrics.cpp 44 44 100.00% []
🔵 be/src/storage/index/vector/vector_index_builder.cpp 5 5 100.00% []
🔵 be/src/runtime/snapshot_loader.cpp 2 2 100.00% []
🔵 be/src/storage/rowset/column_writer.h 1 1 100.00% []
🔵 be/src/storage/index/vector/vector_index_builder_factory.h 1 1 100.00% []

@alvin-celerdata alvin-celerdata merged commit e740667 into StarRocks:main Aug 7, 2024
47 of 51 checks passed
ZiheLiu added a commit to ZiheLiu/starrocks that referenced this pull request Aug 12, 2024
ZiheLiu added a commit to ZiheLiu/starrocks that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support vector index and ANNS.
5 participants