Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix NPE when replaying of adding sub partition #49433

Merged

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Aug 6, 2024

Why I'm doing:

When replaying from old image, there is a NPE.

What I'm doing:

Fix NPE when replaying of adding sub partition.

Fixes https://github.com/StarRocks/StarRocksTest/issues/8326

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@xiangguangyxg xiangguangyxg requested a review from a team as a code owner August 6, 2024 07:41
@github-actions github-actions bot added the 3.3 label Aug 6, 2024
@meegoo meegoo enabled auto-merge (squash) August 6, 2024 07:47
Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

github-actions bot commented Aug 6, 2024

[FE Incremental Coverage Report]

fail : 1 / 2 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/Partition.java 1 2 50.00% [235]

Copy link

github-actions bot commented Aug 6, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@andyziye andyziye disabled auto-merge August 6, 2024 10:29
@andyziye andyziye merged commit 8f1060e into StarRocks:main Aug 6, 2024
50 of 51 checks passed
Copy link

github-actions bot commented Aug 6, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 6, 2024
Copy link
Contributor

mergify bot commented Aug 6, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 6, 2024
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 8f1060e)
wanpengfei-git pushed a commit that referenced this pull request Aug 6, 2024
@xiangguangyxg xiangguangyxg deleted the fix_physical_partition_replay branch August 7, 2024 01:49
@github-actions github-actions bot added the 3.3 label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants