Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize performance of roaring2range #49435

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Aug 6, 2024

Why I'm doing:

What I'm doing:

  1. The interface SparseRange<T>::add is not friendly for add continous range, will result in high frequency memory allocation and cpu usage.
  2. When there are many values ​​in bitmap, next_range is called more often.
  3. Remove _last_value from BitmapRangeIterator
  4. Remove max_range_size from interface next_range.

Performance test

select count(*) from xxx; // 30,000,000 line

mysqlslap -uroot -hxxx -Pxxx --create-schema=ssb_20 --concurrency=20 --number-of-queries=1000 --query='select count(*) from xxx where lo_partkey=300000;'

image

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu trueeyu requested review from a team as code owners August 6, 2024 08:46
@mergify mergify bot assigned trueeyu Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Aug 6, 2024

[BE Incremental Coverage Report]

pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/rowset/bitmap_range_iterator.h 6 6 100.00% []
🔵 be/src/storage/roaring2range.h 1 1 100.00% []

@wyb wyb merged commit 847a755 into StarRocks:main Aug 6, 2024
52 checks passed
@trueeyu
Copy link
Contributor Author

trueeyu commented Aug 12, 2024

@Mergifyio backport branch-3.3

Copy link
Contributor

mergify bot commented Aug 12, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 12, 2024
@github-actions github-actions bot added the 3.3 label Aug 23, 2024
@trueeyu
Copy link
Contributor Author

trueeyu commented Aug 23, 2024

https://github.com/Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Aug 23, 2024

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot added the 3.2 label Aug 23, 2024
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants