Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Provide clear error message if skip_headers is set in select from files option #49503

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[Enhancement] Provide clear error message if skip_headers is set in select from files option #49503

merged 1 commit into from
Aug 8, 2024

Conversation

tracymacding
Copy link
Contributor

@tracymacding tracymacding commented Aug 7, 2024 •
edited by yingtingdong
Loading

Why I'm doing:

What I'm doing:

Fixes #42799

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

  • Yes, translate English markdown files with GPT
  • Do not translate

@tracymacding tracymacding requested a review from a team as a code owner August 7, 2024 06:39
meegoo
meegoo previously approved these changes Aug 7, 2024
View reviewed changes
wyb
wyb previously approved these changes Aug 7, 2024
View reviewed changes
@wyb wyb enabled auto-merge (squash) August 7, 2024 08:44
auto-merge was automatically disabled August 8, 2024 01:49

Head branch was pushed to by a user without write access

@tracymacding tracymacding dismissed stale reviews from wyb and meegoo via 88cef5f August 8, 2024 01:49
@tracymacding tracymacding force-pushed the fix_select_files_err_msg branch 3 times, most recently from 25fc77a to 3913370 Compare August 8, 2024 01:55
kevincai
kevincai previously approved these changes Aug 8, 2024
View reviewed changes
@tracymacding tracymacding force-pushed the fix_select_files_err_msg branch 2 times, most recently from f65e125 to 633c1af Compare August 8, 2024 06:38
meegoo
meegoo previously approved these changes Aug 8, 2024
View reviewed changes
wyb
wyb previously approved these changes Aug 8, 2024
View reviewed changes
@wyb wyb enabled auto-merge (squash) August 8, 2024 07:00
auto-merge was automatically disabled August 8, 2024 08:51

Head branch was pushed to by a user without write access

@tracymacding tracymacding dismissed stale reviews from wyb and meegoo via 7cad0c8 August 8, 2024 08:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb enabled auto-merge (squash) August 8, 2024 11:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

[BE Incremental Coverage Report]

✅ pass : 6 / 7 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/csv_scanner.cpp 6 7 85.71% [271]

@wyb wyb merged commit 51ce589 into StarRocks:main Aug 8, 2024
60 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Aug 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@tracymacding @mergify
[Enhancement] Provide clear error message if skip_headers is set in s…
b82c198 
…elect from files option (#49503)

Signed-off-by: tracymacding <[email protected]>
(cherry picked from commit 51ce589)
@mergify mergify bot mentioned this pull request Aug 8, 2024
Merged
44 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@tracymacding @mergify
[Enhancement] Provide clear error message if skip_headers is set in s…
e3562d7 
…elect from files option (#49503)

Signed-off-by: tracymacding <[email protected]>
(cherry picked from commit 51ce589)

# Conflicts:
#	be/src/exec/csv_scanner.cpp
#	be/test/exec/csv_scanner_test.cpp
@mergify mergify bot mentioned this pull request Aug 8, 2024
Closed
44 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@tracymacding @mergify
[Enhancement] Provide clear error message if skip_headers is set in s…
151a789 
…elect from files option (#49503)

Signed-off-by: tracymacding <[email protected]>
(cherry picked from commit 51ce589)

# Conflicts:
#	be/src/exec/csv_scanner.cpp
#	be/test/exec/csv_scanner_test.cpp
@mergify mergify bot mentioned this pull request Aug 8, 2024
Closed
44 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@tracymacding @mergify
[Enhancement] Provide clear error message if skip_headers is set in s…
51609db 
…elect from files option (#49503)

Signed-off-by: tracymacding <[email protected]>
(cherry picked from commit 51ce589)

# Conflicts:
#	be/src/exec/csv_scanner.cpp
#	be/test/exec/csv_scanner_test.cpp
@mergify mergify bot mentioned this pull request Aug 8, 2024
Closed
44 tasks
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @tracymacding
[Enhancement] Provide clear error message if skip_headers is set in s…
8d2d338 
…elect from files option (backport #49503) (#49600)

Co-authored-by: tracymacding <[email protected]>
@jaogoy
Copy link
Contributor

jaogoy commented Aug 20, 2024

ignore backport check: 3.1.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@kevincai kevincai kevincai approved these changes

@meegoo meegoo meegoo left review comments

Assignees

@tracymacding tracymacding

Labels
3.0 3.1 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[table function format:csv] when csv.skip_header value greater than actual rows, error message is incorrect
5 participants
@tracymacding @jaogoy @kevincai @wyb @meegoo