Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix error message of kill #49518

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[BugFix] fix error message of kill #49518

merged 1 commit into from
Aug 7, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Aug 7, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

  • Yes, translate English markdown files with GPT
  • Do not translate

@murphyatwork
fix error message
a0f8e23 
Signed-off-by: Murphy <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/StmtExecutor.java 1 1 100.00% []

@murphyatwork murphyatwork merged commit 7b5ac67 into StarRocks:main Aug 7, 2024
56 of 57 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Aug 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 7, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 7, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 7, 2024
@murphyatwork @mergify
[BugFix] fix error message of kill (#49518)
2bcbc24 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 7b5ac67)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
@mergify mergify bot mentioned this pull request Aug 7, 2024
Merged
44 tasks
mergify bot pushed a commit that referenced this pull request Aug 7, 2024
@murphyatwork @mergify
[BugFix] fix error message of kill (#49518)
e84b17e 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 7b5ac67)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
@mergify mergify bot mentioned this pull request Aug 7, 2024
Merged
44 tasks
murphyatwork added a commit that referenced this pull request Aug 8, 2024
@murphyatwork
[BugFix] fix error message of kill (#49518)
ffe9267 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 7b5ac67)
murphyatwork added a commit that referenced this pull request Aug 8, 2024
@murphyatwork
[BugFix] fix error message of kill (#49518)
4a373cf 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 7b5ac67)
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @murphyatwork
[BugFix] fix error message of kill (backport #49518) (#49538)
b1566d0 
Co-authored-by: Murphy <[email protected]>
murphyatwork added a commit that referenced this pull request Aug 8, 2024
@mergify @murphyatwork
[BugFix] fix error message of kill (backport #49518) (#49537)
5e22591 
Co-authored-by: Murphy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@packy92 packy92 packy92 approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@murphyatwork murphyatwork

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murphyatwork @Seaven @packy92