Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize routine load task schedule strategy, the distribution of nodes is as even as possible in scenarios with large differences in task scale. #49542

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Aug 7, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

  • Yes, translate English markdown files with GPT
  • Do not translate

@mergify mergify bot assigned meegoo Aug 7, 2024
…ibution of nodes is as even as possible in scenarios with large differences in task scale.

Signed-off-by: meegoo <[email protected]>
Copy link

sonarcloud bot commented Aug 13, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 38 / 45 (84.44%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/routineload/RoutineLoadTaskScheduler.java 1 4 25.00% [300, 301, 360]
🔵 com/starrocks/load/routineload/RoutineLoadJob.java 5 7 71.43% [715, 716]
🔵 com/starrocks/load/routineload/RoutineLoadMgr.java 32 34 94.12% [245, 246]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@meegoo meegoo merged commit 5c35b97 into StarRocks:main Aug 13, 2024
47 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 13, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Aug 13, 2024
Copy link
Contributor

mergify bot commented Aug 13, 2024

Copy link
Contributor

mergify bot commented Aug 13, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 13, 2024
…ibution of nodes is as even as possible in scenarios with large differences in task scale. (#49542)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 5c35b97)
mergify bot pushed a commit that referenced this pull request Aug 13, 2024
…ibution of nodes is as even as possible in scenarios with large differences in task scale. (#49542)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 5c35b97)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadJob.java
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadMgr.java
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadTaskScheduler.java
#	fe/fe-core/src/test/java/com/starrocks/load/routineload/RoutineLoadManagerTest.java
wanpengfei-git pushed a commit that referenced this pull request Aug 14, 2024
…ibution of nodes is as even as possible in scenarios with large differences in task scale. (backport #49542) (#49758)

Co-authored-by: meegoo <[email protected]>
@github-actions github-actions bot added the 3.3 label Sep 2, 2024
meegoo added a commit that referenced this pull request Sep 3, 2024
…ibution of nodes is as even as possible in scenarios with large differences in task scale. (backport #49542) (#49759)

Co-authored-by: meegoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants