Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] desc iceberg table with transform type (backport #49094) #49594

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 8, 2024

Why I'm doing:

What I'm doing:

iceberg partition spec: https://iceberg.apache.org/spec/#partition-transforms
Fixes #issue
image

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #49094 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

iceberg partition spec: https://iceberg.apache.org/spec/#partition-transforms
Fixes #issue
image

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: stephen <[email protected]>
(cherry picked from commit 4855c19)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/IcebergTable.java
#	fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergApiConverter.java
#	fe/fe-core/src/test/java/com/starrocks/qe/ShowExecutorTest.java
@mergify mergify bot added the conflicts label Aug 8, 2024
Copy link
Contributor Author

mergify bot commented Aug 8, 2024

Cherry-pick of 4855c19 has failed:

On branch mergify/bp/branch-3.2/pr-49094
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 4855c19b37.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AstToStringBuilder.java
	modified:   fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveMetadataTest.java
	new file:   test/sql/test_iceberg/R/test_iceberg_show_stmt
	new file:   test/sql/test_iceberg/T/test_iceberg_show_stmt

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/IcebergTable.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergApiConverter.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/qe/ShowExecutorTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Aug 8, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-49094 branch August 8, 2024 09:32
@stephen-shelby stephen-shelby restored the mergify/bp/branch-3.2/pr-49094 branch August 8, 2024 10:56
@stephen-shelby stephen-shelby reopened this Aug 8, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 8, 2024 10:56
Signed-off-by: stephen <[email protected]>
stephen-shelby
stephen-shelby previously approved these changes Aug 8, 2024
Signed-off-by: stephen <[email protected]>
Copy link

sonarcloud bot commented Aug 8, 2024

@wanpengfei-git wanpengfei-git merged commit 797a071 into branch-3.2 Aug 8, 2024
27 of 28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-49094 branch August 8, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants