Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] improve partial update by column mode overflow estimate strategy (backport #50300) #50538

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2024

Why I'm doing:

In previous PR #49054, I introduced partial_update_memory_limit_per_worker to prevent ArrayColumn object overflow (larger than 4GB), but still some issue remain. Because I use the avg column data size to estimate how large ArrayColumn object can be, and it will still overflow when multi columns were updated and one of them is much larger than others.

What I'm doing:

Using whole rows in upt file to estimate how large ArrayColumn object instead of using the avg column data size. It may lead to overvalue but it's still better than undervalue which will lead to overflow.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50300 done by [Mergify](https://mergify.com). ## Why I'm doing: In previous PR #49054, I introduced `partial_update_memory_limit_per_worker` to prevent `ArrayColumn` object overflow (larger than 4GB), but still some issue remain. Because I use the avg column data size to estimate how large `ArrayColumn` object can be, and it will still overflow when multi columns were updated and one of them is much larger than others.

What I'm doing:

Using whole rows in upt file to estimate how large ArrayColumn object instead of using the avg column data size. It may lead to overvalue but it's still better than undervalue which will lead to overflow.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

… strategy (#50300)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0b2eebf)
@wanpengfei-git wanpengfei-git merged commit bc35986 into branch-3.2 Sep 2, 2024
35 of 36 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-50300 branch September 2, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants