[Enhancement] improve partial update by column mode overflow estimate strategy (backport #50300) #50538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In previous PR #49054, I introduced
partial_update_memory_limit_per_worker
to preventArrayColumn
object overflow (larger than 4GB), but still some issue remain. Because I use the avg column data size to estimate how largeArrayColumn
object can be, and it will still overflow when multi columns were updated and one of them is much larger than others.What I'm doing:
Using whole rows in
upt
file to estimate how largeArrayColumn
object instead of using the avg column data size. It may lead to overvalue but it's still better than undervalue which will lead to overflow.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #50300 done by [Mergify](https://mergify.com). ## Why I'm doing: In previous PR #49054, I introduced `partial_update_memory_limit_per_worker` to prevent `ArrayColumn` object overflow (larger than 4GB), but still some issue remain. Because I use the avg column data size to estimate how large `ArrayColumn` object can be, and it will still overflow when multi columns were updated and one of them is much larger than others.
What I'm doing:
Using whole rows in
upt
file to estimate how largeArrayColumn
object instead of using the avg column data size. It may lead to overvalue but it's still better than undervalue which will lead to overflow.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: