[BugFix] Make create_directories compatible with symbolic links #50858

nshangyiming · 2024-09-09T10:10:00Z

Why I'm doing:

E20240904 23:24:35.532979 140392654292800 starrocks_be.cpp:269] BE http server did not start correctly, exiting: create /opt/starrocks/app/be/log recursive: Not a directory
E20240904 23:24:35.532979 140392654292800 starrocks_be.cpp:269] BE http server did not start correctly, exiting: create /opt/starrocks/app/be/log recursive: Not a directory
E20240904 23:24:35.532979 140392654292800 starrocks_be.cpp:269] BE http server did not start correctly, exiting: create /opt/starrocks/app/be/log recursive: Not a directory

What I'm doing:

create_directories() should be compatible with the scenario where dirname exists as a symbolic link
and linked to an existing directory. On CentOS create_directories() will fail in this situation,
but on Ubuntu, it won't. So we make a precheck here in order to have the same expected behavior
on both and probably all the other platforms.

Fixes #45518

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

kevincai · 2024-09-09T10:26:46Z

link to #45518

be/src/fs/fs_posix.cpp

nshangyiming · 2024-09-18T03:01:17Z

@mergify rebase

Signed-off-by: Dejun Xia <[email protected]>

mergify · 2024-09-18T03:01:52Z

rebase

✅ Branch has been successfully rebased

Signed-off-by: Dejun Xia <[email protected]>

kevincai

thought this PR was merged long time ago...

Signed-off-by: Dejun Xia <[email protected]>

github-actions · 2024-09-24T10:12:07Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-24T10:12:20Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-24T10:22:59Z

[BE Incremental Coverage Report]

❌ fail : 6 / 8 (75.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/fs/fs_posix.cpp	6	8	75.00%	[540, 545]

github-actions · 2024-09-24T11:06:58Z

@Mergifyio backport branch-3.3

github-actions · 2024-09-24T11:06:59Z

@Mergifyio backport branch-3.2

github-actions · 2024-09-24T11:07:01Z

@Mergifyio backport branch-3.1

mergify · 2024-09-24T11:07:05Z

backport branch-3.3

✅ Backports have been created

#51332 [BugFix] Make create_directories compatible with symbolic links (backport #50858) has been created for branch branch-3.3

mergify · 2024-09-24T11:07:06Z

backport branch-3.2

✅ Backports have been created

#51333 [BugFix] Make create_directories compatible with symbolic links (backport #50858) has been created for branch branch-3.2

mergify · 2024-09-24T11:07:07Z

backport branch-3.1

✅ Backports have been created

#51334 [BugFix] Make create_directories compatible with symbolic links (backport #50858) has been created for branch branch-3.1

create_directories() should be compatible with the scenario where dirname exists as a symbolic link and linked to an existing directory. On CentOS create_directories() will fail in this situation, but on Ubuntu, it won't. So we make a precheck here in order to have the same expected behavior on both and probably all the other platforms. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 3271d90)

…port #50858) (#51332) Co-authored-by: yiming <[email protected]>

…port #50858) (#51333) Co-authored-by: yiming <[email protected]>

…port #50858) (#51334) Co-authored-by: yiming <[email protected]>

…Rocks#50858) create_directories() should be compatible with the scenario where dirname exists as a symbolic link and linked to an existing directory. On CentOS create_directories() will fail in this situation, but on Ubuntu, it won't. So we make a precheck here in order to have the same expected behavior on both and probably all the other platforms. Signed-off-by: Dejun Xia <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

nshangyiming requested a review from a team as a code owner September 9, 2024 10:10

github-actions bot added 3.3 3.2 3.1 labels Sep 9, 2024

mergify bot assigned nshangyiming Sep 9, 2024

nshangyiming enabled auto-merge (squash) September 9, 2024 10:10

kevincai reviewed Sep 9, 2024

View reviewed changes

be/src/fs/fs_posix.cpp Outdated Show resolved Hide resolved

Astralidea reviewed Sep 9, 2024

View reviewed changes

be/src/fs/fs_posix.cpp Show resolved Hide resolved

Astralidea previously approved these changes Sep 9, 2024

View reviewed changes

nshangyiming dismissed Astralidea’s stale review via 0e600d7 September 10, 2024 07:28

srlch approved these changes Sep 10, 2024

View reviewed changes

nshangyiming force-pushed the fix_create_dirs branch from 0e600d7 to a6b10ce Compare September 10, 2024 07:48

nshangyiming added 3 commits September 18, 2024 03:01

[BugFix] Make create_directories compatible with symbolic links

f64282c

Signed-off-by: Dejun Xia <[email protected]>

fix format

0c2be51

Signed-off-by: Dejun Xia <[email protected]>

fix clang tidy

60193f2

Signed-off-by: Dejun Xia <[email protected]>

nshangyiming force-pushed the fix_create_dirs branch from a6b10ce to 60193f2 Compare September 18, 2024 03:01

nshangyiming added 2 commits September 18, 2024 17:55

fix ut coverage

bb2448a

Signed-off-by: Dejun Xia <[email protected]>

fix ut

ba1390e

Signed-off-by: Dejun Xia <[email protected]>

kevincai previously approved these changes Sep 19, 2024

View reviewed changes

fix ut

1358a5a

Signed-off-by: Dejun Xia <[email protected]>

nshangyiming dismissed kevincai’s stale review via 1358a5a September 24, 2024 07:46

fix ut

5c078c7

Signed-off-by: Dejun Xia <[email protected]>

decster approved these changes Sep 24, 2024

View reviewed changes

gengjun-git approved these changes Sep 24, 2024

View reviewed changes

nshangyiming merged commit 3271d90 into StarRocks:main Sep 24, 2024
42 of 43 checks passed

github-actions bot removed 3.3 3.2 labels Sep 24, 2024

github-actions bot removed the 3.1 label Sep 24, 2024

mergify bot mentioned this pull request Sep 24, 2024

[BugFix] Make create_directories compatible with symbolic links (backport #50858) #51332

Merged

42 tasks

mergify bot mentioned this pull request Sep 24, 2024

[BugFix] Make create_directories compatible with symbolic links (backport #50858) #51333

Merged

42 tasks

mergify bot mentioned this pull request Sep 24, 2024

[BugFix] Make create_directories compatible with symbolic links (backport #50858) #51334

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024

[BugFix] Make create_directories compatible with symbolic links (back…

04764f8

…port #50858) (#51332) Co-authored-by: yiming <[email protected]>

github-actions bot added the 3.3-merged label Sep 24, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024

[BugFix] Make create_directories compatible with symbolic links (back…

084320a

…port #50858) (#51333) Co-authored-by: yiming <[email protected]>

wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024

[BugFix] Make create_directories compatible with symbolic links (back…

1307c9c

…port #50858) (#51334) Co-authored-by: yiming <[email protected]>

github-actions bot added 3.2-merged 3.1-merged labels Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Make create_directories compatible with symbolic links #50858

[BugFix] Make create_directories compatible with symbolic links #50858

nshangyiming commented Sep 9, 2024 •

edited by kevincai

Loading

kevincai commented Sep 9, 2024

nshangyiming commented Sep 18, 2024

mergify bot commented Sep 18, 2024

kevincai left a comment

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

mergify bot commented Sep 24, 2024 •

edited

Loading

mergify bot commented Sep 24, 2024 •

edited

Loading

mergify bot commented Sep 24, 2024 •

edited

Loading

[BugFix] Make create_directories compatible with symbolic links #50858

[BugFix] Make create_directories compatible with symbolic links #50858

Conversation

nshangyiming commented Sep 9, 2024 • edited by kevincai Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

kevincai commented Sep 9, 2024

nshangyiming commented Sep 18, 2024

mergify bot commented Sep 18, 2024

✅ Branch has been successfully rebased

kevincai left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 24, 2024

[FE Incremental Coverage Report]

github-actions bot commented Sep 24, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Sep 24, 2024

[BE Incremental Coverage Report]

file detail

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

mergify bot commented Sep 24, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 24, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 24, 2024 • edited Loading

✅ Backports have been created

nshangyiming commented Sep 9, 2024 •

edited by kevincai

Loading

mergify bot commented Sep 24, 2024 •

edited

Loading

mergify bot commented Sep 24, 2024 •

edited

Loading

mergify bot commented Sep 24, 2024 •

edited

Loading