Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix the npe of show routine load #50963

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[BugFix] Fix the npe of show routine load #50963

merged 1 commit into from
Sep 19, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Sep 11, 2024

Why I'm doing:

What I'm doing:

2024-09-11 10:29:29.274+08:00 WARN (starrocks-mysql-nio-pool-0|199) [StmtExecutor.execute():749] execute Exception, sql show routine load
 java.lang.NullPointerException
        at com.starrocks.load.routineload.RoutineLoadJob.getShowInfo(RoutineLoadJob.java:1532)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
        at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
        at java.base/java.util.stream.StreamSpliterators$SliceSpliterator$OfRef.forEachRemaining(StreamSpliterators.java:740)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
        at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:952)
        at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:926)
        at java.base/java.util.stream.AbstractTask.compute(AbstractTask.java:327)
        at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:408)
        at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:736)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateParallel(ReduceOps.java:919)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
        at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
        at com.starrocks.qe.ShowExecutor$ShowExecutorVisitor.visitShowRoutineLoadStatement(ShowExecutor.java:1143)
        at com.starrocks.qe.ShowExecutor$ShowExecutorVisitor.visitShowRoutineLoadStatement(ShowExecutor.java:286)
        at com.starrocks.sql.ast.ShowRoutineLoadStmt.accept(ShowRoutineLoadStmt.java:169)
        at com.starrocks.sql.ast.AstVisitor.visit(AstVisitor.java:71)
        at com.starrocks.qe.ShowExecutor.execute(ShowExecutor.java:283)
        at com.starrocks.qe.StmtExecutor.handleShow(StmtExecutor.java:1698)
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:689)
        at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:360)
        at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:559)
        at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:894)
        at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:69)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 18, 2024

@Mergifyio rebase main

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024

rebase main

✅ Branch has been successfully rebased

@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 18, 2024

https://github.com/Mergifyio rebase main

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024

rebase main

✅ Branch has been successfully rebased

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 26 / 27 (96.30%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/routineload/PulsarRoutineLoadJob.java 14 15 93.33% [268]
🔵 com/starrocks/load/routineload/RoutineLoadJob.java 12 12 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) September 19, 2024 02:11
@meegoo meegoo merged commit 5bc037d into StarRocks:main Sep 19, 2024
46 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 19, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@trueeyu @mergify
[BugFix] Fix the npe of show routine load (#50963)
5ce7458 
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 5bc037d)
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@trueeyu @mergify
[BugFix] Fix the npe of show routine load (#50963)
8e78ff0 
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 5bc037d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadJob.java
#	fe/fe-core/src/test/java/com/starrocks/load/routineload/RoutineLoadJobTest.java
@mergify mergify bot mentioned this pull request Sep 19, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@trueeyu @mergify
[BugFix] Fix the npe of show routine load (#50963)
5391fd8 
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 5bc037d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadJob.java
#	fe/fe-core/src/test/java/com/starrocks/load/routineload/RoutineLoadJobTest.java
This was referenced Sep 19, 2024
Merged
Open
wanpengfei-git pushed a commit that referenced this pull request Sep 20, 2024
@mergify @trueeyu
[BugFix] Fix the npe of show routine load (backport #50963) (#51141)
fe137ea 
Co-authored-by: trueeyu <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 20, 2024
@mergify @trueeyu
[BugFix] Fix the npe of show routine load (backport #50963) (#51142)
6eb366f 
Signed-off-by: trueeyu <[email protected]>
Co-authored-by: trueeyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@meegoo meegoo meegoo approved these changes

Assignees

@trueeyu trueeyu

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueeyu @wyb @meegoo