Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add command to show the dropped meta information that can be recovered #51007

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rohitrs1983
Copy link
Contributor

@rohitrs1983 rohitrs1983 commented Sep 12, 2024

Why I'm doing:

What I'm doing:

image
image

Fixes #51006

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai
Copy link
Contributor

fantastic!

Copy link

sonarcloud bot commented Sep 22, 2024

Copy link

[FE Incremental Coverage Report]

fail : 46 / 88 (52.27%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/ast/ShowCatalogRecycleBinStmt.java 0 15 00.00% [25, 26, 27, 28, 29, 30, 31, 32, 33, 36, 37, 40, 41, 45, 50]
🔵 com/starrocks/sql/ast/AstVisitor.java 0 1 00.00% [1477]
🔵 com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java 0 11 00.00% [2525, 2526, 2528, 2529, 2530, 2532, 2533, 2534, 2535, 2536, 2537]
🔵 com/starrocks/qe/ShowExecutor.java 0 3 00.00% [2682, 2683, 2684]
🔵 com/starrocks/catalog/CatalogRecycleBin.java 46 58 79.31% [927, 928, 929, 931, 950, 951, 952, 954, 973, 974, 975, 977]

@wyb
Copy link
Contributor

wyb commented Nov 1, 2024

better to implement this insystem table?

@rohitrs1983 rohitrs1983 requested a review from a team as a code owner November 3, 2024 15:23
@wanpengfei-git wanpengfei-git requested a review from a team November 3, 2024 15:23
@rohitrs1983
Copy link
Contributor Author

better to implement this insystem table?

@wyb updated to implement in system table.

Copy link

sonarcloud bot commented Nov 3, 2024

Copy link

github-actions bot commented Nov 3, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 3, 2024

[BE Incremental Coverage Report]

fail : 0 / 2 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/schema_scanner.cpp 0 1 00.00% [217]
🔵 src/exec/schema_scanner/schema_helper.h 0 1 00.00% [114]

@kevincai
Copy link
Contributor

kevincai commented Nov 5, 2024

@rohitrs1983 @wyb wondering if still needs the show catalog recyle bin, either change it to show proc '/a/b/c' or the system table is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] add command to show the dropped meta information that can be recovered
4 participants