[Enhancement] Fix Profile collect bug when log dir is removed #51027

gengjun-git · 2024-09-13T12:58:17Z

Why I'm doing:

What I'm doing:

Fixes

2024-09-13 20:44:20.822+08:00 ERROR (ProcProfileCollector|72) [Daemon.run():109] daemon thread got exception. name: ProcProfileCollector
java.lang.NullPointerException: null
        at com.starrocks.memory.ProcProfileCollector.deleteExpiredFiles(ProcProfileCollector.java:178) ~[starrocks-fe.jar:?]
        at com.starrocks.memory.ProcProfileCollector.runAfterCatalogReady(ProcProfileCollector.java:75) ~[starrocks-fe.jar:?]
        at com.starrocks.common.util.FrontendDaemon.runOneCycle(FrontendDaemon.java:72) ~[starrocks-fe.jar:?]
        at com.starrocks.common.util.Daemon.run(Daemon.java:107) ~[starrocks-fe.jar:?]

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: gengjun-git <[email protected]>

gengjun-git · 2024-09-19T02:50:26Z

@Mergifyio rebase

mergify · 2024-09-19T02:51:03Z

rebase

✅ Branch has been successfully rebased

starrocks-xupeng · 2024-09-19T08:16:20Z

fe/fe-core/src/main/java/com/starrocks/memory/ProcProfileCollector.java

-            initialized = true;
-        }
+        File file = new File(profileLogDir);
+        file.mkdirs();


check first? no need to mkdir every time?

There is check in mkdirs()

public boolean mkdirs() { if (exists()) { return false; } if (mkdir()) { return true; } File canonFile = null; try { canonFile = getCanonicalFile(); } catch (IOException e) { return false; } File parent = canonFile.getParentFile(); return (parent != null && (parent.mkdirs() || parent.exists()) && canonFile.mkdir()); }

Signed-off-by: gengjun-git <[email protected]>

sonarcloud · 2024-09-19T09:25:03Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-actions · 2024-09-19T10:43:06Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-19T10:43:40Z

[FE Incremental Coverage Report]

✅ pass : 23 / 28 (82.14%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/memory/ProcProfileCollector.java	23	28	82.14%	[132, 134, 135, 141, 180]

github-actions · 2024-09-19T10:43:53Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-23T02:24:42Z

@Mergifyio backport branch-3.3

github-actions · 2024-09-23T02:24:43Z

@Mergifyio backport branch-3.2

github-actions · 2024-09-23T02:24:44Z

@Mergifyio backport branch-3.1

mergify · 2024-09-23T02:24:46Z

backport branch-3.3

✅ Backports have been created

#51257 [Enhancement] Fix Profile collect bug when log dir is removed (backport #51027) has been created for branch branch-3.3

mergify · 2024-09-23T02:24:47Z

backport branch-3.2

✅ Backports have been created

#51259 [Enhancement] Fix Profile collect bug when log dir is removed (backport #51027) has been created for branch branch-3.2

mergify · 2024-09-23T02:24:51Z

backport branch-3.1

✅ Backports have been created

#51260 [Enhancement] Fix Profile collect bug when log dir is removed (backport #51027) has been created for branch branch-3.1

Fixes ``` 2024-09-13 20:44:20.822+08:00 ERROR (ProcProfileCollector|72) [Daemon.run():109] daemon thread got exception. name: ProcProfileCollector java.lang.NullPointerException: null at com.starrocks.memory.ProcProfileCollector.deleteExpiredFiles(ProcProfileCollector.java:178) ~[starrocks-fe.jar:?] at com.starrocks.memory.ProcProfileCollector.runAfterCatalogReady(ProcProfileCollector.java:75) ~[starrocks-fe.jar:?] at com.starrocks.common.util.FrontendDaemon.runOneCycle(FrontendDaemon.java:72) ~[starrocks-fe.jar:?] at com.starrocks.common.util.Daemon.run(Daemon.java:107) ~[starrocks-fe.jar:?] ``` Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit 598c81c)

#51027) (#51260) Co-authored-by: gengjun-git <[email protected]>

#51027) (#51259) Co-authored-by: gengjun-git <[email protected]>

#51027) (#51257) Co-authored-by: gengjun-git <[email protected]>

…cks#51027) Fixes ``` 2024-09-13 20:44:20.822+08:00 ERROR (ProcProfileCollector|72) [Daemon.run():109] daemon thread got exception. name: ProcProfileCollector java.lang.NullPointerException: null at com.starrocks.memory.ProcProfileCollector.deleteExpiredFiles(ProcProfileCollector.java:178) ~[starrocks-fe.jar:?] at com.starrocks.memory.ProcProfileCollector.runAfterCatalogReady(ProcProfileCollector.java:75) ~[starrocks-fe.jar:?] at com.starrocks.common.util.FrontendDaemon.runOneCycle(FrontendDaemon.java:72) ~[starrocks-fe.jar:?] at com.starrocks.common.util.Daemon.run(Daemon.java:107) ~[starrocks-fe.jar:?] ``` Signed-off-by: gengjun-git <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

fix

c24dfac

Signed-off-by: gengjun-git <[email protected]>

mergify bot assigned gengjun-git Sep 13, 2024

github-actions bot added 3.3 3.2 3.1 labels Sep 13, 2024

gengjun-git force-pushed the fix_profile_collect_bug branch from c24dfac to 2a63987 Compare September 19, 2024 02:51

starrocks-xupeng reviewed Sep 19, 2024

View reviewed changes

fi

a9b03d5

Signed-off-by: gengjun-git <[email protected]>

gengjun-git force-pushed the fix_profile_collect_bug branch from 2a63987 to a9b03d5 Compare September 19, 2024 09:19

gengjun-git enabled auto-merge (squash) September 19, 2024 12:01

HangyuanLiu approved these changes Sep 23, 2024

View reviewed changes

nshangyiming approved these changes Sep 23, 2024

View reviewed changes

gengjun-git merged commit 598c81c into StarRocks:main Sep 23, 2024
45 of 46 checks passed

github-actions bot removed the 3.3 label Sep 23, 2024

github-actions bot removed the 3.2 label Sep 23, 2024

github-actions bot removed the 3.1 label Sep 23, 2024

mergify bot mentioned this pull request Sep 23, 2024

[Enhancement] Fix Profile collect bug when log dir is removed (backport #51027) #51257

Merged

42 tasks

mergify bot mentioned this pull request Sep 23, 2024

[Enhancement] Fix Profile collect bug when log dir is removed (backport #51027) #51259

Merged

42 tasks

mergify bot mentioned this pull request Sep 23, 2024

[Enhancement] Fix Profile collect bug when log dir is removed (backport #51027) #51260

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Sep 23, 2024

[Enhancement] Fix Profile collect bug when log dir is removed (backport

b8662c0

#51027) (#51260) Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.1-merged label Sep 23, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 23, 2024

[Enhancement] Fix Profile collect bug when log dir is removed (backport

92c6c1f

#51027) (#51259) Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.2-merged label Sep 23, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024

[Enhancement] Fix Profile collect bug when log dir is removed (backport

b08a200

#51027) (#51257) Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.3-merged label Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Fix Profile collect bug when log dir is removed #51027

[Enhancement] Fix Profile collect bug when log dir is removed #51027

gengjun-git commented Sep 13, 2024

gengjun-git commented Sep 19, 2024

mergify bot commented Sep 19, 2024

starrocks-xupeng Sep 19, 2024

gengjun-git Sep 19, 2024

sonarcloud bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

mergify bot commented Sep 23, 2024 •

edited

Loading

mergify bot commented Sep 23, 2024 •

edited

Loading

mergify bot commented Sep 23, 2024 •

edited

Loading

[Enhancement] Fix Profile collect bug when log dir is removed #51027

[Enhancement] Fix Profile collect bug when log dir is removed #51027

Conversation

gengjun-git commented Sep 13, 2024

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

gengjun-git commented Sep 19, 2024

mergify bot commented Sep 19, 2024

✅ Branch has been successfully rebased

starrocks-xupeng Sep 19, 2024

Choose a reason for hiding this comment

gengjun-git Sep 19, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Sep 19, 2024

Quality Gate failed

github-actions bot commented Sep 19, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Sep 19, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Sep 19, 2024

[BE Incremental Coverage Report]

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

mergify bot commented Sep 23, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 23, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 23, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 23, 2024 •

edited

Loading

mergify bot commented Sep 23, 2024 •

edited

Loading

mergify bot commented Sep 23, 2024 •

edited

Loading