[Refactor] Remove log_error from RuntimeState #51137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -549,9 +529,6 @@ class RuntimeState { | |||
| // Lock protecting _error_log and _unreported_error_idx | |||
| std::mutex _error_log_lock; | |||
There was a problem hiding this comment.
Can this lock be removed too?
There was a problem hiding this comment.
No, this can't be remove, it will be used to write error log of load to disk
There was a problem hiding this comment.
void RuntimeState::append_error_msg_to_file(const std::string& line, const std::string& error_msg, bool is_summary) {
std::lock_guard<std::mutex> l(_error_log_lock);
if (_query_options.query_type != TQueryType::LOAD) {
return;
}
// If file havn't been opened, open it here
if (_error_log_file == nullptr) {
Status status = create_error_log_file();
if (!status.ok()) {
LOG(WARNING) << "Create error file log failed. because: " << status.message();
if (_error_log_file != nullptr) {
_error_log_file->close();
delete _error_log_file;
_error_log_file = nullptr;
}
return;
}
}
trueeyu
changed the title
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio rebase main |
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
✅ Branch has been successfully rebased |
trueeyu
force-pushed
the
remove_log_error
branch
from
87bf202
to
947e2b4
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 2 / 4 (50.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
log_error will not be used by fe now, so it's safe to remove it.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: