Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix stream load load_finish_time updated unexpected after transaction committed #51174

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Sep 19, 2024

Why I'm doing:

mysql> select * from _statistics_.loads_history where label='stream_load_1726737200632_4eM'\G;
*************************** 1. row ***************************
                  id: 20038
               label: stream_load_1726737200632_4eM
          profile_id: NULL
             db_name: ingestion_db
          table_name: duplicate_200_column_7CR
                user: root
           warehouse: NULL
               state: COMMITED
            progress: 0%
                type: STREAM_LOAD
            priority: NORMAL
           scan_rows: 0
          scan_bytes: -1
       filtered_rows: -1
     unselected_rows: -1
           sink_rows: -1
     runtime_details: {"begin_txn_time_ms": 0, "client_ip": "172.26.93.220", "load_id": "6648aa87-3649-e16b-8446-79b1dbf473b5", "plan_time_ms": 0, "receive_data_time_ms": 0, "txn_id": 8234}
         create_time: 2024-09-19 17:13:20
     load_start_time: NULL
    load_commit_time: NULL
    load_finish_time: 2024-09-19 17:13:46
          properties: {"timeout": 3600}
           error_msg: NULL
        tracking_sql: select tracking_log from information_schema.load_tracking_logs where job_id=20038
rejected_record_path: NULL
              job_id: 20038
*************************** 2. row ***************************
                  id: 20038
               label: stream_load_1726737200632_4eM
          profile_id: NULL
             db_name: ingestion_db
          table_name: duplicate_200_column_7CR
                user: root
           warehouse: NULL
               state: FINISHED
            progress: 100%
                type: STREAM_LOAD
            priority: NORMAL
           scan_rows: 0
          scan_bytes: 4849
       filtered_rows: 0
     unselected_rows: 0
           sink_rows: 1
     runtime_details: {"begin_txn_time_ms": 0, "client_ip": "172.26.93.220", "load_id": "6648aa87-3649-e16b-8446-79b1dbf473b5", "plan_time_ms": 8, "receive_data_time_ms": 0, "txn_id": 8234}
         create_time: 2024-09-19 17:13:20
     load_start_time: NULL
    load_commit_time: NULL
    load_finish_time: 2024-09-19 17:16:10
          properties: {"timeout": 3600}
           error_msg:
        tracking_sql: NULL
rejected_record_path: NULL
              job_id: 20038
2 rows in set (0.02 sec)

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo changed the title [BugFix] Fix stream load load_finish_time updated unexpected after tr… [BugFix] Fix stream load load_finish_time updated unexpected after tansaction committed Sep 19, 2024
@meegoo meegoo changed the title [BugFix] Fix stream load load_finish_time updated unexpected after tansaction committed [BugFix] Fix stream load load_finish_time updated unexpected after transaction committed Sep 19, 2024
@mergify mergify bot assigned meegoo Sep 19, 2024
@wanpengfei-git wanpengfei-git requested a review from a team September 19, 2024 13:42
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 6 / 11 (54.55%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/streamload/StreamLoadTask.java 6 11 54.55% [621, 693, 961, 1005, 1123]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) September 20, 2024 01:57
@wanpengfei-git wanpengfei-git merged commit 49ef20f into StarRocks:main Sep 23, 2024
47 of 49 checks passed
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 23, 2024
Copy link
Contributor

mergify bot commented Sep 23, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 23, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 23, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 23, 2024
…ansaction committed (#51174)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 49ef20f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/streamload/StreamLoadTask.java
#	fe/fe-core/src/test/java/com/starrocks/load/streamload/StreamLoadManagerTest.java
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
…ansaction committed (#51174)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 49ef20f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/streamload/StreamLoadTask.java
#	fe/fe-core/src/test/java/com/starrocks/load/streamload/StreamLoadManagerTest.java
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
…ansaction committed (#51174)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 49ef20f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/streamload/StreamLoadTask.java
#	fe/fe-core/src/test/java/com/starrocks/load/streamload/StreamLoadManagerTest.java
wanpengfei-git pushed a commit that referenced this pull request Sep 27, 2024
…ansaction committed (backport #51174) (#51265)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: meegoo <[email protected]>
meegoo added a commit that referenced this pull request Oct 9, 2024
…ansaction committed (backport #51174) (#51264)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: meegoo <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants