Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Cached fragment misuses exogenous runtime filter (backport #51150) #51198

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

Why I'm doing:

image
Cached fragment(Fragment 0) should not use exogenous runtime filters produced by remote fragment(Fragment 2's HashJoin(2) ), since the HashJoin(2)'s runtime filter changes as its the right side changes. so we should disable query cache in this situation.

When we take this into conderation , we use PlanFragment.get{Build,Probe}RuntimeFilters methods to obtain fragment-specific runtime filter informations that are not be collected before using.

What I'm doing:

Collection runtime filter build/probe information in PlanFragmentBuilder

+        fragments.forEach(PlanFragment::collectBuildRuntimeFilters);
+        fragments.forEach(PlanFragment::collectProbeRuntimeFilters);

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51150 done by [Mergify](https://mergify.com). ## Why I'm doing: ![image](https://github.com/user-attachments/assets/49eb87f9-97b5-40ca-9804-7f6519c4e19b) Cached fragment(Fragment 0) should not use exogenous runtime filters produced by remote fragment(Fragment 2's HashJoin(2) ), since the HashJoin(2)'s runtime filter changes as its the right side changes. so we should disable query cache in this situation.

When we take this into conderation , we use PlanFragment.get{Build,Probe}RuntimeFilters methods to obtain fragment-specific runtime filter informations that are not be collected before using.

What I'm doing:

Collection runtime filter build/probe information in PlanFragmentBuilder

+        fragments.forEach(PlanFragment::collectBuildRuntimeFilters);
+        fragments.forEach(PlanFragment::collectProbeRuntimeFilters);

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Sep 20, 2024

@wanpengfei-git wanpengfei-git merged commit bba4b21 into branch-3.3 Sep 20, 2024
35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-51150 branch September 20, 2024 07:21
smartlxh pushed a commit to smartlxh/starrocks that referenced this pull request Oct 16, 2024
…backport StarRocks#51150) (StarRocks#51198)

本次代码评审主要涉及优化和重构,包括在多个类中添加新导入、改进运行时过滤器的收集逻辑、调整数据结构以使用HashMap、以及增强PlanFragment的节点收集方法,同时调整了FragmentNormalizer的逻辑,整体提高了代码的结构清晰度和运行时过滤器处理的效率。
Link: https://code.alibaba-inc.com/soe/starrocks/codereview/18493054
* [Backport][BugFix] Cached fragment misuses exogenous runtime filter (backport StarRocks#51150) (StarRocks#51198)

Co-authored-by: satanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants