Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] enable adaptive partition hash join by default #51224

Merged
merged 1 commit into from
Sep 27, 2024
Merged

[Enhancement] enable adaptive partition hash join by default #51224

merged 1 commit into from
Sep 27, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Sep 20, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain stdpain force-pushed the enable_partition_hash_join_by_default branch from 43733d8 to 7686955 Compare September 20, 2024 11:36
@stdpain stdpain requested a review from a team as a code owner September 20, 2024 11:36
@stdpain stdpain force-pushed the enable_partition_hash_join_by_default branch 3 times, most recently from 1b3452d to 893452b Compare September 26, 2024 03:07
@stdpain stdpain force-pushed the enable_partition_hash_join_by_default branch from 893452b to 709a921 Compare September 26, 2024 12:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 12 / 12 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/types/logical_type_infra.h 2 2 100.00% []
🔵 be/src/exec/pipeline/hashjoin/spillable_hash_join_build_operator.cpp 9 9 100.00% []
🔵 be/src/exec/hash_join_components.cpp 1 1 100.00% []

@trueeyu trueeyu merged commit 26de537 into StarRocks:main Sep 27, 2024
48 of 49 checks passed
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@stdpain @renzhimin7
[Enhancement] enable adaptive partition hash join by default (StarRoc…
52543a3 
…ks#51224)

Signed-off-by: stdpain <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@stdpain stdpain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stdpain @Seaven @trueeyu