Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix refresh mv error when hive table has null values in the partition (#51238) #51240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kobebryantlin0
Copy link
Contributor

@kobebryantlin0 kobebryantlin0 commented Sep 20, 2024

Why I'm doing:

When creating a materialized view for Hive Catalog with string type partition, an error occurs when the partition key has __HIVE_DEFAULT_PARTITION__ value .

What I'm doing:

Fixes #51238

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kobebryantlin0
Copy link
Contributor Author

kobebryantlin0 commented Sep 20, 2024

@LiShuMing could you please review this pr with issue

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link
Contributor

@LiShuMing LiShuMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done. LGTM.

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kobebryantlin0
Copy link
Contributor Author

@trueeyu @kevincai could you please review this pr? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] throw "Invalid data type for creating infinity:VARCHAR" error when do refresh mv
3 participants