Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Refactor CachingMvPlanContextBuilder to support timeout in loading mv's plan cache (backport #52424) #52492

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 31, 2024

Why I'm doing:

CachingMvPlanContextBuilder#getPlanContext may block user's query's process or even stuck/hang.

What I'm doing:

  • Move getOrLoadPlanContext by using a backgroud thread pool(Config.mv_plan_cache_thread_pool_size, default 3 thread)
  • Remove expireAfterAccess's refresh of the mv plan context cache since mv's plan should not be changed
  • Load MV Plan Context async automatically when mv is on load to avoid optimization time in cold run.
  • Add timeout for loading mv's plan cache to avoid hanging user's query.
  • Fix a bug in testing: CachedPartitionTraits should take care mv either beside the base table.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52424 done by [Mergify](https://mergify.com). ## Why I'm doing: `CachingMvPlanContextBuilder#getPlanContext` may block user's query's process or even stuck/hang.

What I'm doing:

  • Move getOrLoadPlanContext by using a backgroud thread pool(Config.mv_plan_cache_thread_pool_size, default 3 thread)
  • Remove expireAfterAccess's refresh of the mv plan context cache since mv's plan should not be changed
  • Load MV Plan Context async automatically when mv is on load to avoid optimization time in cold run.
  • Add timeout for loading mv's plan cache to avoid hanging user's query.
  • Fix a bug in testing: CachedPartitionTraits should take care mv either beside the base table.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

… in loading mv's plan cache (#52424)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 03e23c2)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/alter/AlterMVJobExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvRewritePreprocessor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/function/MetaFunctions.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/rule/SingleTableRewriteBaseRule.java
Copy link
Contributor Author

mergify bot commented Oct 31, 2024

Cherry-pick of 03e23c2 has failed:

On branch mergify/bp/branch-3.2/pr-52424
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 03e23c21d2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/common/Config.java
	modified:   fe/fe-core/src/main/java/com/starrocks/connector/ConnectorPartitionTraits.java
	modified:   fe/fe-core/src/main/java/com/starrocks/connector/partitiontraits/CachedPartitionTraits.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/BestMvSelector.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
	modified:   fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorOlapPart2Test.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewritePreprocessorTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java
	modified:   test/sql/test_materialized_view/R/test_mv_reasoning

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/alter/AlterMVJobExecutor.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvRewritePreprocessor.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/function/MetaFunctions.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/rule/SingleTableRewriteBaseRule.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Oct 31, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 31, 2024 05:59
@mergify mergify bot closed this Oct 31, 2024
auto-merge was automatically disabled October 31, 2024 06:00

Pull request was closed

Copy link
Contributor Author

mergify bot commented Oct 31, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@LiShuMing LiShuMing reopened this Nov 4, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 4, 2024 02:32
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Nov 4, 2024

@wanpengfei-git wanpengfei-git merged commit 291891b into branch-3.2 Nov 4, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-52424 branch November 4, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants