-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Refactor CachingMvPlanContextBuilder to support timeout in loading mv's plan cache (backport #52424) #52492
Conversation
… in loading mv's plan cache (#52424) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 03e23c2) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/alter/AlterMVJobExecutor.java # fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvRewritePreprocessor.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/function/MetaFunctions.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/rule/SingleTableRewriteBaseRule.java
Cherry-pick of 03e23c2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Quality Gate passedIssues Measures |
Why I'm doing:
CachingMvPlanContextBuilder#getPlanContext
may block user's query's process or even stuck/hang.What I'm doing:
getOrLoadPlanContext
by using a backgroud thread pool(Config.mv_plan_cache_thread_pool_size, default 3 thread)expireAfterAccess
's refresh of the mv plan context cache since mv's plan should not be changedtimeout
for loading mv's plan cache to avoid hanging user's query.CachedPartitionTraits
should take caremv
either beside the base table.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #52424 done by [Mergify](https://mergify.com). ## Why I'm doing: `CachingMvPlanContextBuilder#getPlanContext` may block user's query's process or even stuck/hang.
What I'm doing:
getOrLoadPlanContext
by using a backgroud thread pool(Config.mv_plan_cache_thread_pool_size, default 3 thread)expireAfterAccess
's refresh of the mv plan context cache since mv's plan should not be changedtimeout
for loading mv's plan cache to avoid hanging user's query.CachedPartitionTraits
should take caremv
either beside the base table.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: