[Feature] table sample #52600
Open
[Feature] table sample #52600
+1,384
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murphyatwork
force-pushed
the
murphy_feat_table_sample
branch
5 times, most recently
from
64435a6
to
46bfe29
Compare
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
murphyatwork
force-pushed
the
murphy_feat_table_sample
branch
from
acf9bfe
to
bc37039
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 61 / 85 (71.76%) file detail
|
[BE Incremental Coverage Report]✅ pass : 272 / 322 (84.47%) file detail
|
satanson
reviewed
Nov 11, 2024
| @@ -259,9 +261,11 @@ class ColumnIterator { | |||
|
|
|||
| virtual Status null_count(size_t* count) { return Status::OK(); }; | |||
|
|
|||
| // RAW interface, should be used carefully | |||
| virtual ColumnReader* get_column_reader() { return nullptr; }; | |||
There was a problem hiding this comment.
suggest to
virtual ColumnReader* get_column_reader()=0;
or use std::optional<ColumnReader*> as a return type to tell sb that the return type must be checked
| std::bernoulli_distribution dist(_probability_percent / 100.0); | ||
|
|
||
| size_t sampled_blocks = 0; | ||
| size_t total_blocks = _total_rows / _rows_per_block; |
There was a problem hiding this comment.
how _rows_per_block is deduced? it seems _rows_per_block is deduced from rows per block
| for (size_t i = 0; i < _total_rows; i += _rows_per_block) { | ||
| if (dist(mt)) { | ||
| sampled_blocks++; | ||
| sampled_ranges.add(RowIdRange(i, std::min(i + _rows_per_block, _total_rows))); |
There was a problem hiding this comment.
- can RowIdRange span two blocks ? a interesting question is what's the math expect of number of RowIdRanges spanning two block when stride(_rows_per_block) varies. is there an optimized stride?
|
|
||
| double SortableZoneMap::width(const Datum& lhs, const Datum& rhs) { | ||
| if (lhs.is_null() || rhs.is_null()) { | ||
| return 0; |
There was a problem hiding this comment.
why is 0, it seems that is a open range, it seens that infinity or maximum value is reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Introduce a syntax for table sample:
Properties:
seed: optional, specify the random seed, which can guarantee the deterministic resultmethod: optional,by_blockorby_pagepercent:(0, 100), sample probabilityFixes #52787
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: