-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Trino dialect, the extract function supports dow and week parameters #52651
Open
renzhimin7
wants to merge
4
commits into
StarRocks:main
Choose a base branch
from
renzhimin7:extract-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renzhimin7
force-pushed
the
extract-main
branch
from
November 5, 2024 16:06
89d8ba7
to
6ab8cda
Compare
miomiocat
previously approved these changes
Nov 7, 2024
Signed-off-by: zhiminr.ren <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
auto-merge was automatically disabled
November 8, 2024 08:34
Head branch was pushed to by a user without write access
renzhimin7
force-pushed
the
extract-main
branch
from
November 8, 2024 08:34
6ab8cda
to
9c3515f
Compare
Youngwb
reviewed
Nov 8, 2024
fe/fe-core/src/main/java/com/starrocks/connector/parser/trino/AstBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: zhiminr.ren <[email protected]>
[FE Incremental Coverage Report]✅ pass : 4 / 4 (100.00%) file detail
|
Signed-off-by: zhiminr.ren <[email protected]>
Quality Gate passedIssues Measures |
Youngwb
approved these changes
Nov 12, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #52698
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: