Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix compute node replay heartbeat response status inconsistency #52694

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Nov 7, 2024

  • fix inconstent retry times
  • properly handle mismatching of retry times between the heartbeat response generated and the heartbeat response replayed.

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai kevincai requested a review from a team as a code owner November 7, 2024 08:01
* fix inconstent retry times
* properly handle mismatching of retry times between the heartbeat
  response generated and the heartbeat response replayed.

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

github-actions bot commented Nov 7, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 7, 2024

[FE Incremental Coverage Report]

pass : 10 / 10 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/system/ComputeNode.java 9 9 100.00% []
🔵 com/starrocks/system/Backend.java 1 1 100.00% []

Copy link

github-actions bot commented Nov 7, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@gengjun-git gengjun-git merged commit 28907b0 into StarRocks:main Nov 7, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants