Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support yearweek function to do const folding #52714

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[Enhancement] Support yearweek function to do const folding #52714

merged 2 commits into from
Nov 8, 2024

Conversation

dirtysalt
Copy link
Contributor

@dirtysalt dirtysalt commented Nov 8, 2024 •
edited
Loading

Why I'm doing:

It's like #47365

What I'm doing:

Do const folding of yearweek at FE level, could lead to potential partition pruning at plan stage.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@dirtysalt dirtysalt requested a review from a team as a code owner November 8, 2024 01:13
@github-actions github-actions bot added the 3.3 label Nov 8, 2024
@dirtysalt dirtysalt requested a review from a team as a code owner November 8, 2024 03:09
@dirtysalt
update files
116b1f8 
Signed-off-by: yanz <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

[FE Incremental Coverage Report]

❌ fail : 10 / 16 (62.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java 10 16 62.50% [531, 532, 551, 552, 553, 554]

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

LiShuMing
LiShuMing approved these changes Nov 8, 2024
View reviewed changes
fe/fe-core/src/test/resources/sql/optimizer/rewrite/year-week-function-test.dat
@@ -0,0 +1,4920 @@
0 1900-01-08 00:00:00 190001 1900-12-24 00:00:00 190051 2000-01-08 00:00:00 200001 2000-12-24 00:00:00 200052
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive cases!

@dirtysalt dirtysalt enabled auto-merge (squash) November 8, 2024 05:45
@kangkaisen kangkaisen merged commit 6425ac1 into StarRocks:main Nov 8, 2024
58 of 59 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 8, 2024
@dirtysalt @mergify
[Enhancement] Support yearweek function to do const folding (#52714)
3d47176 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit 6425ac1)
@mergify mergify bot mentioned this pull request Nov 8, 2024
Merged
42 tasks
@dirtysalt dirtysalt deleted the const-fold-yearweek branch November 8, 2024 05:56
wanpengfei-git pushed a commit that referenced this pull request Nov 8, 2024
@mergify @dirtysalt
[Enhancement] Support yearweek function to do const folding (backport
36ec1ff 
#52714) (#52732)

Co-authored-by: RyanZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@Seaven Seaven Seaven approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

@silverbullet233 silverbullet233 silverbullet233 approved these changes

Assignees

@dirtysalt dirtysalt

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dirtysalt @silverbullet233 @LiShuMing @Seaven @stephen-shelby @kangkaisen