Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]Change python interpreter from python to python3 in fe-core module #52734

Closed
wants to merge 1 commit into from

Conversation

monkeyboy123
Copy link

@monkeyboy123 monkeyboy123 commented Nov 8, 2024

Why I'm doing:

It is more reasonable. In Starrrock 3.3.5/master
In some enviroment, python infer python2,it cause error blow, if we build fe using mvn clean install -DskipTests:

ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java:[75,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/system/HeartbeatMgr.java:[44,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/load/streamload/StreamLoadTask.java:[27,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/connector/hive/HiveMetastoreApiConverter.java:[31,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/StarRocksFE.java:[43,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/load/loadv2/LoadLoadingTask.java:[44,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/http/action/IndexAction.java:[38,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/http/rest/FeatureAction.java:[17,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/sql/optimizer/dump/QueryDumpSerializer.java:[29,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/qe/GlobalVariable.java:[39,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common
[ERROR] starrocks/fe/fe-core/src/main/java/com/starrocks/http/rest/BootstrapFinishAction.java:[41,28] cannot find symbol
[ERROR]   symbol:   class Version
[ERROR]   location: package com.starrocks.common

What I'm doing:

Change python interpreter from python to python3
Fixes ##52733

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@monkeyboy123 monkeyboy123 changed the title [FE] Change python interpreter from python to python3 in fe-core module [FE]Change python interpreter from python to python3 in fe-core module Nov 8, 2024
@monkeyboy123 monkeyboy123 changed the title [FE]Change python interpreter from python to python3 in fe-core module [Enhancement]Change python interpreter from python to python3 in fe-core module Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants