Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhance Lock Manager Memory and CPU resource consumption (backport #52705) #52791

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 11, 2024

Why I'm doing:

What I'm doing:

  • Remove meaningless debug logs
  • Remove getStackTrace in the constructor and get it in the slow log instead
  • Add lock type information to the slow log

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52705 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

  • Remove meaningless debug logs
  • Remove getStackTrace in the constructor and get it in the slow log instead
  • Add lock type information to the slow log

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Nov 11, 2024
Copy link
Contributor Author

mergify bot commented Nov 11, 2024

Cherry-pick of 596f2ff has failed:

On branch mergify/bp/branch-3.3/pr-52705
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 596f2ff7f1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/sys/SysFeLocks.java
	modified:   fe/fe-core/src/main/java/com/starrocks/common/util/LogUtil.java
	modified:   fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/LockManager.java
	modified:   fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/MultiUserLock.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Nov 11, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@HangyuanLiu HangyuanLiu reopened this Nov 11, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 11, 2024 07:25
#52705)

Signed-off-by: HangyuanLiu <[email protected]>
(cherry picked from commit 596f2ff)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java
Copy link

sonarcloud bot commented Nov 11, 2024

@wanpengfei-git wanpengfei-git merged commit c32ac26 into branch-3.3 Nov 11, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-52705 branch November 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants