Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Add HistogramMetric to support histogram with tags (backport #52782) #52806

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 11, 2024

Why I'm doing:

  • Histogram can only store tags in the name, if the tag has some special symbols(eg: $), Prometheus cannot parse it.

What I'm doing:

  • Support Histogram metric with tags to distinguish different metrics with the same name.
 * e.g. mv_refresh_duration{mv_db_name="db1", mv_name="mv1"}

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52782 done by [Mergify](https://mergify.com). ## Why I'm doing: - `Histogram` can only store `tags` in the name, if the tag has some special symbols(eg: $), `Prometheus` cannot parse it.

What I'm doing:

  • Support Histogram metric with tags to distinguish different metrics with the same name.
 * e.g. mv_refresh_duration{mv_db_name="db1", mv_name="mv1"}

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit f744c57)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/metric/MaterializedViewMetricsEntity.java
@mergify mergify bot added the conflicts label Nov 11, 2024
Copy link
Contributor Author

mergify bot commented Nov 11, 2024

Cherry-pick of f744c57 has failed:

On branch mergify/bp/branch-3.2/pr-52782
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit f744c57c46.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   fe/fe-core/src/main/java/com/starrocks/metric/HistogramMetric.java
	modified:   fe/fe-core/src/main/java/com/starrocks/metric/JsonMetricVisitor.java
	modified:   fe/fe-core/src/main/java/com/starrocks/metric/MetricVisitor.java
	modified:   fe/fe-core/src/main/java/com/starrocks/metric/PrometheusMetricVisitor.java
	modified:   fe/fe-core/src/main/java/com/starrocks/metric/SimpleCoreMetricVisitor.java
	modified:   fe/fe-core/src/test/java/com/starrocks/metric/MetricsTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/metric/MaterializedViewMetricsEntity.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Nov 11, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant