Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] add tip for data fxns (backport #52810) #52812

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 11, 2024

A reader asked for an example to convert a string to a datetime, and since they would likely be reading the datetime data type doc, I added a tip to look at the SQL functions for dates and times.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52810 done by [Mergify](https://mergify.com). A reader asked for an example to convert a string to a datetime, and since they would likely be reading the datetime data type doc, I added a tip to look at the SQL functions for dates and times.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

(cherry picked from commit c6ebfcf)

# Conflicts:
#	docs/zh/sql-reference/data-types/date-types/DATETIME.md
Copy link
Contributor Author

mergify bot commented Nov 11, 2024

Cherry-pick of c6ebfcf has failed:

On branch mergify/bp/branch-3.2/pr-52810
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit c6ebfcff5b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   docs/en/_assets/commonMarkdown/dateTimeTip.mdx
	modified:   docs/en/sql-reference/data-types/date-types/DATE.md
	modified:   docs/en/sql-reference/data-types/date-types/DATETIME.md
	modified:   docs/en/sql-reference/data-types/date-types/_category_.yml
	new file:   docs/en/sql-reference/data-types/date-types/date-types.mdx
	modified:   docs/en/sql-reference/sql-functions/date-time-functions/_category_.yml
	new file:   docs/en/sql-reference/sql-functions/date-time-functions/date-time-functions.mdx
	new file:   docs/zh/_assets/commonMarkdown/dateTimeTip.mdx
	modified:   docs/zh/sql-reference/data-types/date-types/DATE.md
	modified:   docs/zh/sql-reference/data-types/date-types/_category_.yml
	new file:   docs/zh/sql-reference/data-types/date-types/date-types.mdx
	new file:   docs/zh/sql-reference/sql-functions/date-time-functions/_category_.yml
	new file:   docs/zh/sql-reference/sql-functions/date-time-functions/date-time-functions.mdx

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/zh/sql-reference/data-types/date-types/DATETIME.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 11, 2024
@mergify mergify bot mentioned this pull request Nov 11, 2024
24 tasks
@github-actions github-actions bot added documentation Improvements or additions to documentation automerge labels Nov 11, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 11, 2024 23:26
Copy link
Contributor Author

mergify bot commented Nov 11, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Nov 11, 2024
auto-merge was automatically disabled November 11, 2024 23:26

Pull request was closed

Signed-off-by: DanRoscigno <[email protected]>
@DanRoscigno DanRoscigno reopened this Nov 11, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 11, 2024 23:32
@wanpengfei-git wanpengfei-git merged commit 9efc463 into branch-3.2 Nov 12, 2024
36 of 37 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-52810 branch November 12, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge conflicts documentation Improvements or additions to documentation version:3.2.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants