[Enhancement] Change fe-core compile source/target to 17 #53617
Merged
+181
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
gengjun-git
force-pushed
the
compile_fe_to_jdk_17_byte_code
branch
from
cefd88f to
227258f
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
gengjun-git
force-pushed
the
compile_fe_to_jdk_17_byte_code
branch
2 times, most recently
from
914132e to
bbdad73
Compare
|
@Mergifyio rebase |
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
gengjun-git
force-pushed
the
compile_fe_to_jdk_17_byte_code
branch
from
658e404 to
bec7723
Compare
✅ Branch has been successfully rebased |
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
stephen-shelby
approved these changes
Dec 25, 2024
Youngwb
approved these changes
Dec 25, 2024
gengjun-git
changed the title
maggie-zhu
pushed a commit
to maggie-zhu/starrocks
that referenced
this pull request
Jan 6, 2025
1. Copy UnmodifiableCollectionsSerializer.java to our repository to fix compilable issue: `Unable to make field final java.util.Collection java.util.Collections$UnmodifiableCollection.c accessible: module java.base does not "opens java.util" to unnamed module @61322f9d ` Refer to magro/kryo-serializers#131 2. Upgrade jacoco to 0.8.8 3. For the arrow flight server, users should add `--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` to JAVA_OPTS Refer to https://arrow.apache.org/docs/java/install.html 4. Fix some UT Signed-off-by: gengjun-git <[email protected]>
|
UnmodifiableCollectionsSerialize is also used by IcebergMetadataScanner, so I guess same compilable issue may occur there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Unable to make field final java.util.Collection java.util.Collections$UnmodifiableCollection.c accessible: module java.base does not "opens java.util" to unnamed module @61322f9dRefer to Compatibility with JDK 17 magro/kryo-serializers#131
--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMEDto JAVA_OPTSRefer to https://arrow.apache.org/docs/java/install.html
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: