Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Remove the binary type constrain in HIVE_UNSUPPORTED_TYPES #55375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duanyyyyyyy
Copy link
Contributor

@duanyyyyyyy duanyyyyyyy commented Jan 23, 2025

Why I'm doing:

  1. Currently the SR already supported the binary type for Hive.
  2. If we do not remove the binary type constrain in HIVE_UNSUPPORTED_TYPES we may have the following issue.
    When we query some table that have the column like user_attributes:array<struct<key:string,value:binary>> the user_attributes will be regraded as UNKNOWN_TYPE.
    And then as for the backend we will got the fatal log like the following:
    image

What I'm doing:

Remove the he binary type constrain in HIVE_UNSUPPORTED_TYPES
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@duanyyyyyyy duanyyyyyyy requested a review from a team as a code owner January 23, 2025 10:25
@duanyyyyyyy duanyyyyyyy force-pushed the remove_binary_constrain branch from 20ce2b1 to 6a71ae3 Compare January 23, 2025 10:26
@duanyyyyyyy duanyyyyyyy changed the title [BugFix] Remove the binary type constrain in HIVE_UNSUPPORTED_TYPES [BugFix] Remove the binary type constrain in HIVE_UNSUPPORTED_TYPES Jan 23, 2025
@duanyyyyyyy duanyyyyyyy force-pushed the remove_binary_constrain branch from 6a71ae3 to 0d70fe6 Compare January 23, 2025 14:02
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/ColumnTypeConverter.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant