Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix bugs for iceberg rest catalog #55416

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Jan 24, 2025

Why I'm doing:

fix some bugs for iceberg rest catalog

1. can not query resy catalog and throw exceprion like this

StarRocks>show databases from iceberg_rest;
ERROR 1064 (HY000): Could not initialize class org.apache.hc.client5.http.impl.io.ManagedHttpClientConnectionFactory

this is because starrocks upgrade iceberg to 1.7.1

2. can not show tables and drop view

image

What I'm doing:

  1. add dependency
  2. use lmutable list
  3. rest catalog drop view override the default exception

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Youngwb Youngwb requested a review from a team as a code owner January 24, 2025 07:45
@github-actions github-actions bot added the 3.4 label Jan 24, 2025
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/iceberg/rest/IcebergRESTCatalog.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@dirtysalt dirtysalt enabled auto-merge (squash) January 24, 2025 16:42
@dirtysalt dirtysalt merged commit e52cb9e into StarRocks:main Jan 26, 2025
47 of 48 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 26, 2025
Copy link
Contributor

mergify bot commented Jan 26, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 26, 2025
(cherry picked from commit e52cb9e)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/connector/iceberg/IcebergMetadataTest.java
@Youngwb Youngwb deleted the iceberg_reset branch January 26, 2025 01:54
wanpengfei-git pushed a commit that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants