Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] subfield pushdown through table function #55425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

satanson
Copy link
Contributor

Why I'm doing:

Clone multiple duplicates of entire complex objects like struct instead of its required output subfield in TableFunction Operator is time consuming. so we must support subfield pushdown through table function.

for the query I mentioned in the UT test, this optimization performs well

  1. concurrency=1, speed up 1.799/0.369=4.8X
  2. concurrency=10, speed up 10.172/1.610=6.3X

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

ZiheLiu
ZiheLiu previously approved these changes Jan 24, 2025
@satanson satanson force-pushed the subfield_pushdown_through_tablefunction branch from 15449a8 to 23ffb3f Compare January 26, 2025 02:35
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/LogicalPlanPrinter.java 0 1 00.00% [180]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants