Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Preview is blank after inserting a table #994

Closed
torce opened this issue Nov 21, 2023 · 5 comments · Fixed by #1013
Closed

Preview is blank after inserting a table #994

torce opened this issue Nov 21, 2023 · 5 comments · Fixed by #1013
Labels
bug Something isn't working markdown widgets

Comments

@torce
Copy link

torce commented Nov 21, 2023

The preview frame shows an empty markdown preview after inserting a table.

Screencast.webm
@KaneFreeman KaneFreeman added the bug Something isn't working label Dec 5, 2023
@arctixdev
Copy link

I am experiencing the same bug on beta 16.. I would like to take a stab at fixing the issue

@arctixdev
Copy link

The problem is that in useMdx on the markdown widget in the setValueCallback it fails with
TypeError: Cannot set properties of undefined (setting 'inTable')

For some reason it fails silently

@arctixdev
Copy link

This seems to be the underlying problem: remarkjs/remark-gfm#57 (comment)

@arctixdev
Copy link

Downgrading remark-gfm to 3.0.1 fixes the problem. It is because the entire markdown "ecosystem" apperently changes a lot of stuff and is rolling out new major versions with breaking changes as said here remarkjs/remark-gfm#57 (comment)

The version currently used of remark-gfm (4.0.0) has thoose big changes and therefore breaks.

I have created a pr that downgrades remark-gfm and fixes the issue: #1012

@KaneFreeman
Copy link
Collaborator

Thanks for finding this. I going to opt for upgrading all of the dependencies instead of downgrading. It will have to be done eventually anyways to maintain support. I have opened a PR to address this #1013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working markdown widgets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants