Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

fix: tables in markdown preview (Downgrade remark gfm to 3.0.1) #1012

Closed

Conversation

arctixdev
Copy link

Remark-gfm 4.0.0 is part of the new versions of unified, remark, rehype, and micromark packages. remarkjs/remark-gfm#57 (comment)

Its incompatible with the other packages in static cms

Fixes #994

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit 1f308ae
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/659434251c8b7400080bc2e3
😎 Deploy Preview https://deploy-preview-1012.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit 1f308ae
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/659434252768c200077689bf
😎 Deploy Preview https://deploy-preview-1012.demo.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arctixdev arctixdev changed the title Fix tables in markdown preview (Downgrade remark gfm to 3.0.1) fix: tables in markdown preview (Downgrade remark gfm to 3.0.1) Jan 2, 2024
@KaneFreeman
Copy link
Collaborator

I going to opt for upgrading all of the dependencies instead of downgrading. It will have to be done eventually anyways to maintain support. I am closing this PR in favor of #1013

@KaneFreeman KaneFreeman closed this Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants