Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

fix: properly update duplicated and none i18n fields when default locale updates #934

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

KaneFreeman
Copy link
Collaborator

@KaneFreeman KaneFreeman commented Oct 11, 2023

When in the i18n side by side editor, fields marked duplicate or none are not showing updated values when the default locale's corresponding field is updated.

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit 3285ccd
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/6526e96d819647000800e06f
😎 Deploy Preview https://deploy-preview-934.demo.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit 3285ccd
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/6526e96dc9903d00087806b3
😎 Deploy Preview https://deploy-preview-934.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #934 (3285ccd) into main (1d4ae8e) will decrease coverage by 0.13%.
Report is 3 commits behind head on main.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   52.41%   52.29%   -0.13%     
==========================================
  Files         231      230       -1     
  Lines        9905     9877      -28     
  Branches     2593     2583      -10     
==========================================
- Hits         5192     5165      -27     
+ Misses       4330     4329       -1     
  Partials      383      383              
Files Coverage Δ
packages/core/src/backend.ts 12.50% <100.00%> (ø)
packages/core/src/lib/formatters.ts 66.66% <100.00%> (ø)
packages/core/src/lib/i18n.ts 18.75% <100.00%> (ø)
packages/core/src/reducers/entries.ts 9.28% <100.00%> (ø)
packages/core/src/widgets/string/StringControl.tsx 100.00% <100.00%> (ø)
packages/core/src/widgets/text/TextControl.tsx 100.00% <100.00%> (ø)
packages/core/src/reducers/entryDraft.ts 26.71% <85.71%> (+1.01%) ⬆️

@KaneFreeman KaneFreeman merged commit 7b9d653 into main Oct 11, 2023
@KaneFreeman KaneFreeman deleted the fix/duplicated-none-i18n-field-updating branch October 11, 2023 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant