feat: add uninstall button to store #739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaro-cuesta
commented
Jan 2, 2025
| @@ -32,7 +32,6 @@ const PluginCard: FC<PluginCardProps> = ({ storePlugin, installedPlugin }) => { | |||
|
|
|||
| return ( | |||
| <div | |||
| className="deckyStoreCard" | |||
There was a problem hiding this comment.
These classes seemed unused.
There was a problem hiding this comment.
they exist for theme developers, keep them
There was a problem hiding this comment.
@AAGaming00 done. Also added a small warning documenting this.
alvaro-cuesta
commented
Jan 2, 2025
alvaro-cuesta
commented
Jan 2, 2025
|
@AAGaming00 need you to confirm any questions PR submitter had to make sure there aren't any issues with frontend changes made. Once the frontend changes have been reviewed I'll give this a spin myself. |
|
@alvaro-cuesta please revert 48f23f we should really document this practice... |
Although the classes seemed to be unused, they exist for theme developers. Also add a warning documenting this.
Class was removed in ebc2f52 because it seemed no longer needed after removing some styling, but it's actually there for theme developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
This is a followup to PR #733. After discussing with @TrainDoctor on Discord he suggested it would be a good idea to also add an uninstall button to the store next to the "Reinstall" button (to plugins which are already installed).
To make the functionality more obvious, the button will only be shown on the "Reinstall" case, i.e. when the currently installed version is selected in the dropdown.