-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Change TTL #682
Add Change TTL #682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove debug flag from your plugin.json. I would also like to know why this plugin requires root to perform it's function which can be done without root access via KDE desktop.
AFAIK to change the TTL using sysctl you need root and in the tests I did it is so. I can't find in the KDE settings a related configuration. Can you please share what method could be used without root? |
Apologies, I misunderstood what was meant by TTL and the access levels needed to modify it. What would be the purpose of modifying the TTL for Steam Deck users? (The plugin can go forward now but I'm just curious 😅) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for testing store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuanJoseGonGi please fix your addition to .gitmodules and bring the branch field properly inline with the other fields. I should have caught that from the start. Please also re-add a screenshot URL and a relevant image.
I personally use it to bypass mobile hotspot limits on data plans. I think it could be the main use case for deck |
@TrainDoctor These 2 refer to the image field on the plugin.json? |
Yes, that's correct. |
Closing as untested. If you are able to locate a tester in future we will happily accept a re-submission. |
@JuanJoseGonGi, if you are able to update this PR with a version of your plugin (please also make sure to bump your version by at least a patch to ensure no conflicts will occur in CI/CD etc) that you have verified with the latest stable versions of Loader then I can re-open this PR. (Please note the below text only applies if you are able to make the requested update, thanks for your understanding). The more plugins that can come back the higher chance you are able to see a tester for your plugin is my hope. I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines. |
Change TTL
This plugin changes the default ipv4 and ipv6 TTL to the user specified one using sysctl commands.
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
Tested on SteamOS Stable/Beta Update Channel.
Tested on SteamOS Preview Update Channel.