Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Hillarity Ensued" update (v3 bump) #694

Closed

Conversation

safijari
Copy link
Contributor

HLTB

Update to use the v3 api, fixes flicckering

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@safijari safijari requested a review from a team as a code owner September 12, 2024 18:29
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Off to testing.

@TrainDoctor TrainDoctor requested review from a team September 13, 2024 20:58
@TrainDoctor
Copy link
Member

Closing as untested. If you are able to locate a tester in future we will happily accept a re-submission.

@TrainDoctor
Copy link
Member

@safijari, if you are able to update this PR with a version of your plugin (please also make sure to bump your version by at least a patch to ensure no conflicts will occur in CI/CD etc) that you have verified with the latest stable versions of Loader then I can re-open this PR. (Please note the below text only applies if you are able to make the requested update, thanks for your understanding). The more plugins that can come back the higher chance you are able to see a tester for your plugin is my hope.

I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants