-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DiscordStatus to v1.4.0 #697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for testing.
Any news on this? |
If users like yourself were to submit a testing report as per the guide https://deckbrew.xyz/testing, then this update can move ahead. Since this has not occured: closing as untested. If you are able to locate a tester in future we will happily accept a re-submission. |
So rude, I could try this, I just wanted to know the status of the PR. |
@sawa-ko, you're comment was not the reason for the PR being closed. There is an ongoing policy of if a PR has not been properly tested after at least a month from first submission then it's PR is closed and the author is invited to re-submit the plugin with a tester outside of the developer/dev team. I admit I was not as tactful in my response to your message as I could have been and I apologize for that, but this was not meant as a slight towards you. Since you've expressed your interest in testing this PR, I can re-open this PR for a while longer and once you submit your testing report and it meets all of our expectations, you can expect this PR to merge and the plugin sent to production. |
@andrewburgess if you can rebase your PR on latest main so that CI can have a clear view of the plugin being updated then this PR can proceed again. |
@TrainDoctor done |
Lovely, the action will likely fail because the version number is the same but it will be working all the same. |
@andrewburgess To use this plugin do I need to have the Discord application installed as a desktop application or just log in to the browser? |
@sawa-ko needs to be installed as a desktop app |
Testing ReportVersionsDecky: v3.1.2-pre1 SummaryMajor blocking issuesNone Minor issuesNone Currently installed plugins
Yay/nay on to send to the production store or if it requires more testing.Seems to work as intended. Yay to prod. |
Testing reportDecky Version: 3.1.2-pre1 A) Major IssuesNone found B) Minor IssuesNone found C) Installed Plugins
D) Production Store RecommendationYay Additional NotesNo issues. Properly reports currently played game on discord status |
DiscordStatus
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
Tested on SteamOS Stable/Beta Update Channel.
Tested on SteamOS Preview Update Channel.