Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DiscordStatus to v1.4.0 #697

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

andrewburgess
Copy link
Contributor

DiscordStatus

  • Adds ability to pull "detectable" game list from Discord so that those client IDs can be used when reporting current app
    • Previously, the plugin would use it's own AppId, which resulted in a Discord status saying "Playing SteamDeck"
    • Now, if a game can be matched against Discord's "detectable" list, then that AppId will be used, resulting in the correct game name being displayed in the rich presence

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for testing.

@sawa-ko
Copy link

sawa-ko commented Jan 5, 2025

Any news on this?

@TrainDoctor
Copy link
Member

Any news on this?

If users like yourself were to submit a testing report as per the guide https://deckbrew.xyz/testing, then this update can move ahead. Since this has not occured: closing as untested. If you are able to locate a tester in future we will happily accept a re-submission.

@sawa-ko
Copy link

sawa-ko commented Jan 12, 2025

So rude, I could try this, I just wanted to know the status of the PR.

@TrainDoctor
Copy link
Member

So rude, I could try this, I just wanted to know the status of the PR.

@sawa-ko, you're comment was not the reason for the PR being closed. There is an ongoing policy of if a PR has not been properly tested after at least a month from first submission then it's PR is closed and the author is invited to re-submit the plugin with a tester outside of the developer/dev team. I admit I was not as tactful in my response to your message as I could have been and I apologize for that, but this was not meant as a slight towards you. Since you've expressed your interest in testing this PR, I can re-open this PR for a while longer and once you submit your testing report and it meets all of our expectations, you can expect this PR to merge and the plugin sent to production.

@TrainDoctor
Copy link
Member

@andrewburgess if you can rebase your PR on latest main so that CI can have a clear view of the plugin being updated then this PR can proceed again.

@andrewburgess
Copy link
Contributor Author

@TrainDoctor done

@TrainDoctor
Copy link
Member

@TrainDoctor done

Lovely, the action will likely fail because the version number is the same but it will be working all the same.
@sawa-ko if you wish to give this a proper testing report everything is ready for you to do so.

@sawa-ko
Copy link

sawa-ko commented Jan 13, 2025

@andrewburgess To use this plugin do I need to have the Discord application installed as a desktop application or just log in to the browser?

@andrewburgess
Copy link
Contributor Author

@sawa-ko needs to be installed as a desktop app

@jessebofill
Copy link
Contributor

Testing Report

Versions

Decky: v3.1.2-pre1
SteamOS: v3.6.21 (Beta)

Summary

Major blocking issues

None

Minor issues

None

Currently installed plugins

  • TabMaster - 2.7.3
  • CSS Loader - 2.1.2
  • SteamGridDB - 1.5.1
  • Web Browser - 1.3.3
  • HLTB - 1.5.0
  • Junk-Store - 1.1.7
  • PlayTime - 1.0.0
  • AutoSuspend - 2.1.0
  • Game Theme Music - 1.5.0
  • Animation Changer - 1.3.1
  • MicroSDeck - 0.10.11

Yay/nay on to send to the production store or if it requires more testing.

Seems to work as intended. Yay to prod.

@OMGDuke
Copy link
Contributor

OMGDuke commented Jan 13, 2025

Testing report

Decky Version: 3.1.2-pre1
SteamOS Version: 3.6.20

A) Major Issues

None found

B) Minor Issues

None found

C) Installed Plugins

  • ProtonDB Badges v1.1.0
  • Game Theme Music v1.7.0
  • SteamGridDB v1.5.1
  • Discord Status v1.4.0-4b650a0
  • CSS Loader v2.1.2

D) Production Store Recommendation

Yay

Additional Notes

No issues. Properly reports currently played game on discord status

@TrainDoctor TrainDoctor merged commit 2927e8f into SteamDeckHomebrew:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants