-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Update Tabmaster to v2.7.3 #738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for testing :)
@Tormak9970, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request a member of the SDH team to use testing guidelines and to provide a testing report. |
Decky v3.0.5, SteamOS 3.6.20 NOTE: Upon initial install the plugin got stuck in an initialization loop. It repeatedly output a toast about failing initialization. I checked logs and found this repeated a dozen times:
Followed by this repeated a few dozen times.
Upon reinstall it failed to appear in the Decky Loader plugin list. I saw that my Decky Loader version was out of date so I updated, rebooted, and then the plugin appeared again and has since thrown no errors. I'm guessing this was caused by some weird update state but wanted to document it regardless. If no one else encounters this I'd bet it's just a one off. Dumping logs here just in case, but wanted to document this in case it happens again. A) Any major blocking issues that you encountered, if any.
B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
C) A list of currently installed plugins (Name and version preferred)
D) Yay/nay on to send to the production store or if it requires more testing.
|
I think that's a great idea, I'll submit reports for a couple plugins today |
The reloading issue is a Decky Loader problem as far as we're aware. Its been a thing for a while, and has to do with the websockets iirc |
@TrainDoctor gonna document this here for convenience:
|
If you can provide more detail in an issue on the loader repo that would be appreciated. I'd like to resolve if there is a significant enough issue. |
If there are no other testing reports that confirm the issue noted by jwhitlow (or any other blocking issues) by the end of today PST, this PR will be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, almost forgot to merge this. Thanks for your patience @Tormak9970 and your testing report @jwhitlow45.
Hi Train. Im confused. I only can find version 2.7.2 in the "default" store chanel. Shouldn't the new version 2.7.3 be there? |
CD decided to not actually upload for some reason. Reran CI/CD and it should be uploaded now. |
TabMaster
A couple of bug fixes, you can see them here: https://github.com/Tormak9970/TabMaster/releases/tag/v2.7.3
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
Tested on SteamOS Stable/Beta Update Channel.
Tested on SteamOS Preview Update Channel.