Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update Tabmaster to v2.7.3 #738

Merged
merged 36 commits into from
Jan 14, 2025

Conversation

Tormak9970
Copy link
Contributor

TabMaster

A couple of bug fixes, you can see them here: https://github.com/Tormak9970/TabMaster/releases/tag/v2.7.3

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

Tormak9970 and others added 30 commits July 4, 2023 14:43
@Tormak9970 Tormak9970 requested a review from a team as a code owner December 31, 2024 23:04
Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for testing :)

@TrainDoctor
Copy link
Member

@Tormak9970, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request a member of the SDH team to use testing guidelines and to provide a testing report.

@jwhitlow45
Copy link
Contributor

Decky v3.0.5, SteamOS 3.6.20

NOTE: Upon initial install the plugin got stuck in an initialization loop. It repeatedly output a toast about failing initialization. I checked logs and found this repeated a dozen times:

[2025-01-12 21:07:54,548][INFO]: Initializing Tab Master.
[2025-01-12 21:07:54,569][INFO]: Calling Loader unload function for TabMaster.
[2025-01-12 21:07:54,569][INFO]: Attempting to unload with plugin TabMaster's "_unload" function.

[2025-01-12 21:07:54,569][INFO]: Unloading Tab Master.
[2025-01-12 21:07:54,569][INFO]: Unloaded TabMaster

Followed by this repeated a few dozen times.

[2025-01-12 21:08:05,022][ERROR]: Task was destroyed but it is pending!
task: <Task pending name='Task-505' coro=<WSRouter._call_route() running at decky_loader/wsrouter.py:65> wait_for=<Future pending cb=[Task.task_wakeup()]>>

Upon reinstall it failed to appear in the Decky Loader plugin list. I saw that my Decky Loader version was out of date so I updated, rebooted, and then the plugin appeared again and has since thrown no errors. I'm guessing this was caused by some weird update state but wanted to document it regardless. If no one else encounters this I'd bet it's just a one off. Dumping logs here just in case, but wanted to document this in case it happens again.

logs.zip

A) Any major blocking issues that you encountered, if any.

  • No. Validated bugs mentioned in release notes were fixed, and everything else I interacted with/tried to break was fine.

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).

  • No.

C) A list of currently installed plugins (Name and version preferred)

  • Bluetooth 2.3.0
  • Game Theme Music 1.6.0
  • ProtonDB Badges 1.1.0
  • Audio Loader 1.6.0
  • CSS Loader 2.1.2
  • PowerTools 2.0.3
  • SteamGridDB 1.5.1
  • AutoFlatpaks 1.6.7
  • Animation Changer 1.3.1
  • DeckFAQs 1.8.1
  • vibrantDeck 2.0.1
  • BatteryTracker 0.2.0
  • RadiYo! 1.3
  • Volume Mixer 1.2.1-1
  • Free Loader 1.3.0 (testing version)
  • Tailscale Control 0.1.3

D) Yay/nay on to send to the production store or if it requires more testing.

  • Yay

@Tormak9970
Copy link
Contributor Author

@Tormak9970, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request a member of the SDH team to use testing guidelines and to provide a testing report.

I think that's a great idea, I'll submit reports for a couple plugins today

@Tormak9970
Copy link
Contributor Author

Decky v3.0.5, SteamOS 3.6.20

NOTE: Upon initial install the plugin got stuck in an initialization loop. It repeatedly output a toast about failing initialization. I checked logs and found this repeated a dozen times:

[2025-01-12 21:07:54,548][INFO]: Initializing Tab Master.
[2025-01-12 21:07:54,569][INFO]: Calling Loader unload function for TabMaster.
[2025-01-12 21:07:54,569][INFO]: Attempting to unload with plugin TabMaster's "_unload" function.

[2025-01-12 21:07:54,569][INFO]: Unloading Tab Master.
[2025-01-12 21:07:54,569][INFO]: Unloaded TabMaster

Followed by this repeated a few dozen times.

[2025-01-12 21:08:05,022][ERROR]: Task was destroyed but it is pending!
task: <Task pending name='Task-505' coro=<WSRouter._call_route() running at decky_loader/wsrouter.py:65> wait_for=<Future pending cb=[Task.task_wakeup()]>>

Upon reinstall it failed to appear in the Decky Loader plugin list. I saw that my Decky Loader version was out of date so I updated, rebooted, and then the plugin appeared again and has since thrown no errors. I'm guessing this was caused by some weird update state but wanted to document it regardless. If no one else encounters this I'd bet it's just a one off. Dumping logs here just in case, but wanted to document this in case it happens again.

logs.zip

A) Any major blocking issues that you encountered, if any.

* No. Validated bugs mentioned in release notes were fixed, and everything else I interacted with/tried to break was fine.

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).

* No.

C) A list of currently installed plugins (Name and version preferred)

* Bluetooth 2.3.0

* Game Theme Music 1.6.0

* ProtonDB Badges 1.1.0

* Audio Loader 1.6.0

* CSS Loader 2.1.2

* PowerTools 2.0.3

* SteamGridDB 1.5.1

* AutoFlatpaks 1.6.7

* Animation Changer 1.3.1

* DeckFAQs 1.8.1

* vibrantDeck 2.0.1

* BatteryTracker 0.2.0

* RadiYo! 1.3

* Volume Mixer 1.2.1-1

* Free Loader 1.3.0 (testing version)

* Tailscale Control 0.1.3

D) Yay/nay on to send to the production store or if it requires more testing.

* Yay

The reloading issue is a Decky Loader problem as far as we're aware. Its been a thing for a while, and has to do with the websockets iirc

@Tormak9970
Copy link
Contributor Author

@TrainDoctor gonna document this here for convenience:

@TrainDoctor
Copy link
Member

The reloading issue is a Decky Loader problem as far as we're aware. Its been a thing for a while, and has to do with the websockets iirc

If you can provide more detail in an issue on the loader repo that would be appreciated. I'd like to resolve if there is a significant enough issue.

@TrainDoctor
Copy link
Member

TrainDoctor commented Jan 13, 2025

If there are no other testing reports that confirm the issue noted by jwhitlow (or any other blocking issues) by the end of today PST, this PR will be merged.
Thanks again for all your testing reports @Tormak9970 ❤️.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, almost forgot to merge this. Thanks for your patience @Tormak9970 and your testing report @jwhitlow45.

@TrainDoctor TrainDoctor merged commit 6ddef82 into SteamDeckHomebrew:main Jan 14, 2025
2 checks passed
@nabel0
Copy link

nabel0 commented Jan 15, 2025

Whoops, almost forgot to merge this. Thanks for your patience @Tormak9970 and your testing report @jwhitlow45.

Hi Train. Im confused. I only can find version 2.7.2 in the "default" store chanel. Shouldn't the new version 2.7.3 be there?

@TrainDoctor
Copy link
Member

Whoops, almost forgot to merge this. Thanks for your patience @Tormak9970 and your testing report @jwhitlow45.

Hi Train. Im confused. I only can find version 2.7.2 in the "default" store chanel. Shouldn't the new version 2.7.3 be there?

CD decided to not actually upload for some reason. Reran CI/CD and it should be uploaded now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants