Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Field types for versions #67

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: Field types for versions #67

merged 1 commit into from
Aug 22, 2024

Conversation

gbdlin
Copy link
Contributor

@gbdlin gbdlin commented Aug 12, 2024

  • downloads and uploads were made as non-nullable in database, but they're defined as nullable in model.
  • added_on had wrong field type - it's the same type in DB, but differently handled in code. Adjusted migration to match the model.

@TrainDoctor TrainDoctor requested a review from a team August 12, 2024 22:01
@TrainDoctor TrainDoctor added the enhancement New feature or request label Aug 12, 2024
Base automatically changed from fix/dev-docker-fixes to main August 14, 2024 22:28
- `downloads` and `uploads` were made as non-nullable in database, but
  they're defined as nullable in model.
- `added_on` had wrong field type - it's the same type in DB, but
  differently handled in code. Adjusted migration to match the model.
@gbdlin gbdlin merged commit 4d7ccd6 into main Aug 22, 2024
7 checks passed
@gbdlin gbdlin deleted the fix/field-types branch August 22, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants