Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build on BuildKit (now the default on Actions runners) #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ian-h-chamberlain
Copy link

This may be easiest to review commit-by-commit, particularly the Dockerfile. I tested the build on my fork with my own credentials to make sure everything was working as well.

Changes:

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, not directly approving but not explicitly requiring the version detection change

@ian-h-chamberlain
Copy link
Author

Hey @AAGaming00, it seems like Valve updated the API to actually contain image versions now, so I went ahead and implemented that change, and rebased onto the latest main.

Since 3.5.7 is out on stable now I suppose that building that might be a good test of the changes?

@AAGaming00 AAGaming00 removed the bug Something isn't working label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants