Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Улучшения работы с текстовыми координатами #110

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

Stepami
Copy link
Owner

@Stepami Stepami commented Aug 20, 2024

Description

  • Оптимизировал метод GetLines
  • Вынес конструктор Coordinates в GetCoordinates
  • Добавил xmldoc
  • Покрыл тестами

Related Issues

Closes #107 #109

Copy link

File Coverage Branches Missing
All files 44% 43%

Minimum allowed coverage is 20%

Generated by 🐒 cobertura-action against cff1de2

@Stepami Stepami merged commit df2d0b7 into master Aug 20, 2024
3 checks passed
@Stepami Stepami deleted the feature/text-coord-comp-improv branch August 20, 2024 16:05
Stepami added a commit that referenced this pull request Aug 25, 2024
* #103 - вернул префикс (#104)

* #105 - fix GitVersion.yml +semver:skip (#106)

* #105 - fix GitVersion.yml

* #105 - label->tag

* #97 - внедрение логгера (#108)

* #97 - rename logging -> dumping

* #97 - refactoring of writer entity

* #97 - реализация вывода с помощью логгера

* #97 - реализация форматтера для эквивалентного вывода

* #97 - работа с логгером в тестах

* Улучшения работы с текстовыми координатами (#110)

* #107 - оптимизация ITextCoordinateSystemComputer.GetLines

* #107 - правка тестов

* #109 - Вынос логики построения координат в сервис

* #109 - тесты

---------

Co-authored-by: StefanioHabrArticles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant